Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grant/fund redesign #2921

Merged
merged 5 commits into from
Nov 26, 2018
Merged

grant/fund redesign #2921

merged 5 commits into from
Nov 26, 2018

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Nov 22, 2018

Description

untitled

@captnseagraves / @mbeacom could you help test this out before merge ?
I'm having issues at me end getting token and I'm not able to test out the contribute flow

There aren't any changes in the JS code but still as a precaution

Update: got it working :P

screen shot 2018-11-26 at 2 13 02 pm

@willsputra
Copy link
Contributor

@thelostone-mc lgtm design-wise. 😁

@codecov
Copy link

codecov bot commented Nov 24, 2018

Codecov Report

❗ No coverage uploaded for pull request base (grants@64f428a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             grants    #2921   +/-   ##
=========================================
  Coverage          ?   17.05%           
=========================================
  Files             ?      175           
  Lines             ?    13867           
  Branches          ?     1813           
=========================================
  Hits              ?     2365           
  Misses            ?    11494           
  Partials          ?        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64f428a...68affd3. Read the comment docs.

@thelostone-mc
Copy link
Member Author

thelostone-mc commented Nov 24, 2018

I realized that the connect metamask check wasn't added and we didn't do the metamask check in the contribute fund section.
So added that in another individual commit

cc @SaptakS could you check this commit cause you wrote it up the first time and encountered some version issues

untitled

@thelostone-mc thelostone-mc merged commit 1c5d869 into gitcoinco:grants Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants