Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitcoin Pajamas #2907

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Gitcoin Pajamas #2907

merged 3 commits into from
Nov 21, 2018

Conversation

Dgilliams
Copy link
Contributor

@Dgilliams Dgilliams commented Nov 21, 2018

Description

Organic hand stitched pajamas with the gitcoin logo

  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

Avatar builder

Testing

tested on chrome using docker and windows 10 pro.

pjs_1
pjs2
pjs3
pjs4
pjs5
pjs6

@codecov
Copy link

codecov bot commented Nov 21, 2018

Codecov Report

Merging #2907 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2907   +/-   ##
=======================================
  Coverage   29.98%   29.98%           
=======================================
  Files         171      171           
  Lines       13428    13428           
  Branches     1789     1789           
=======================================
  Hits         4027     4027           
  Misses       9268     9268           
  Partials      133      133
Impacted Files Coverage Δ
app/avatar/utils.py 17.73% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e1cf6c...fe08f99. Read the comment docs.

@owocki owocki merged commit f056805 into gitcoinco:master Nov 21, 2018
@owocki
Copy link
Contributor

owocki commented Nov 21, 2018

@Dgilliams - the hero we need. the hero we deserve

@gitcoinbot
Copy link
Member

⚡️ A tip worth 30.00000 DAI (30.0 USD @ $1.0/DAI) has been granted to @Dgilliams for this issue from @owocki. ⚡️

The sender had the following public comments:

@Dgilliams - the hero we need. the hero we deserve

Nice work @Dgilliams! Your tip has automatically been deposited in the ETH address we have on file.

@gitcoinbot
Copy link
Member

⚡️ A *Magical Unicorn* Kudos has been sent to @Dgilliams for this issue from @owocki. ⚡️

Nice work @Dgilliams!
Your Kudos has automatically been sent in the ETH address we have on file.

@owocki
Copy link
Contributor

owocki commented Nov 21, 2018

hmmm i dont see this on the avatar builder even after deploying https://gitcoin.co/onboard/profile/?steps=avatar#section-title

@mbeacom
Copy link
Contributor

mbeacom commented Nov 21, 2018

Looks like it's there 🤔

screenshot 2018-11-21 12 58 58

@owocki
Copy link
Contributor

owocki commented Nov 22, 2018

oh thx, i must have missed it.. or my static wasn't reloaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants