More Qa fixes #2902
Merged
More Qa fixes #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser cant select token if one required by grant creator. Core systems shouldnt be affected, but will test in morning.
mbeacom
approved these changes
Nov 21, 2018
| @@ -291,6 +291,7 @@ def grant_fund(request, grant_id): | |||
| 'active': 'fund_grant', | |||
| 'title': _('Fund Grant'), | |||
| 'subscription': {}, | |||
| 'grant_has_no_token': True if grant.token_address == '0x0000000000000000000000000000000000000000' else False, | |||
There was a problem hiding this comment.
@captnseagraves Somewhat similar to what we discussed about the not reserved word, you can do something like:
'grant_has_no_token': grant.token == '0x0000000000000000000000000000000000000000'
Codecov Report
@@ Coverage Diff @@
## grants #2902 +/- ##
=========================================
- Coverage 30.23% 30.2% -0.03%
=========================================
Files 169 169
Lines 13463 13454 -9
Branches 1765 1765
=========================================
- Hits 4070 4064 -6
+ Misses 9269 9266 -3
Partials 124 124
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More Qa fixes for #2862 (comment)
remove ETH and add Any Token to token drop downs. Also, ensure that user cant select token if one required by grant creator. Core systems shouldnt be affected, but will test in morning.