[WOC] PR@2764: Update corner case canceling started issue #2811
Conversation
|
tbh I think we gotta have to do a backend audit in the near future anyways, as the platform grows we are not allowed to get screwed over by beginner errors, I think. Prolly gotta talk to Kevin and set up something so we can put that into scope. |
Codecov Report
@@ Coverage Diff @@
## master #2811 +/- ##
==========================================
- Coverage 30.41% 30.38% -0.04%
==========================================
Files 216 216
Lines 17223 17223
Branches 2332 2332
==========================================
- Hits 5239 5233 -6
- Misses 11776 11782 +6
Partials 208 208
Continue to review full report at Codecov.
|
|
@kuhnchris I was hoping to include the restriction on the BE as well, but if you're opposed to adding it right now, I guess we can merge it and I'll try to tackle it at some point, time permitting. |
|
Your decision, that PR at least fixes the front-end side (for now). |
|
@kuhnchris would be super neat if we could throw it into the BE if you are up for it ? ^_^ |
mbeacom
changed the title
|
Anything you need from us here? @kuhnchris |
|
ah pardon me, didn't see the reply. want me to implement that check on backend side aswell (just that check) or want me to create a build-ticket to check this in general? |
|
@kuhnchris would be ideal :P or do you just wanna resolve the conflicts and roll with this ? |
|
I do not mind either way. If the official statement is "fix be aswell" then I'll fix it, we just do not want to let this fall through the roof. |
|
@thelostone-mc you still know if this is still out there and causing issues? else I'd suggest we throw this away! Thanks! |
| if (fromAddress != web3.eth.coinbase) { | ||
| errormsg = | ||
| gettext('Only the address that submitted this funded issue may kill the bounty.'); | ||
| if (bountyAmount > 0 && !is_open) { |
There was a problem hiding this comment.
parseInt(0.09, 10)>0 will be false
0.09 > 0 will be true (what we want)
Description
Additional check for open == false but other things being true to show additional info message.
Checklist
Affected core subsystem(s)
UI
Testing
Cannot test due to broken pyvips :-(
Refers/Fixes
Fixes: #2764