Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce casing / formatting rules for profiles #2775

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Nov 12, 2018

per convo in slack

@owocki
Copy link
Contributor Author

owocki commented Nov 12, 2018

testing

In [1]: from dashboard.models import Profile

In [2]: owocki = Profile.objects.get(handle='owocki')

In [3]: owocki.handle = '@OWOCKI '

In [4]: owocki.save()

In [5]: owocki = Profile.objects.get(handle='owocki')

In [6]: owocki.handl,e
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-6-2eff224d1db4> in <module>
----> 1 owocki.handl,e

AttributeError: 'Profile' object has no attribute 'handl'

In [7]: owocki.handle
Out[7]: 'owocki'

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚢 :shipit:

@owocki owocki merged commit 810d572 into master Nov 12, 2018
@mbeacom mbeacom added backend This needs backend expertise. and removed in progress labels Nov 12, 2018
@mbeacom mbeacom deleted the kevin/prfile_casing branch November 12, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This needs backend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants