Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explorer: filters revamp #2744

Merged
merged 5 commits into from
Nov 13, 2018
Merged

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Nov 9, 2018

Description
  • restructures files
  • removes dead code ( also ios app css code )
  • updated to match user interface for the filters on the explorer
  • is mobile friendly
  • hide search history
Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Testing

untitled

Refers/Fixes

@codecov
Copy link

codecov bot commented Nov 10, 2018

Codecov Report

Merging #2744 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2744   +/-   ##
=======================================
  Coverage   28.89%   28.89%           
=======================================
  Files         163      163           
  Lines       13080    13080           
  Branches     1753     1753           
=======================================
  Hits         3780     3780           
  Misses       9193     9193           
  Partials      107      107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea059fb...54cfb58. Read the comment docs.

- displays count of bounties
- hides search history
Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing in my local here this look amazing.
There is some issue when I try to get into a issue, looks like there is some call for shared/codefund_banner.html

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to take out the banner call inside the issue details. Tested all the code and after that LGTM

@thelostone-mc
Copy link
Member Author

@octavioamu removed ^_^
thanks for that :D

@octavioamu octavioamu merged commit 4dd7e49 into gitcoinco:master Nov 13, 2018
@thelostone-mc thelostone-mc deleted the explorer branch November 20, 2018 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants