tip/kudos receive fixes #2728
tip/kudos receive fixes #2728
Conversation
app/assets/onepager/js/receive.js
Outdated
| @@ -35,7 +35,9 @@ window.onload = function() { | |||
| if (document.web3network != document.network) { | |||
| _alert({ message: gettext('You are not on the right web3 network. Please switch to ') + document.network }, 'error'); | |||
| } else { | |||
| $('#forwarding_address').val(web3.eth.coinbase); | |||
| if(!$('#forwarding_address').val()){ | |||
There was a problem hiding this comment.
Expected space(s) after "if". (keyword-spacing)
Unexpected if as the only statement in an else block. (no-lonely-if)
Missing space before opening brace. (space-before-blocks)
app/assets/onepager/js/receive.js
Outdated
| @@ -73,6 +75,11 @@ $(document).ready(function() { | |||
| return; | |||
| } | |||
|
|
|||
| if(!confirm(gettext('Please confirm that ' + forwarding_address + ' is the address for which you wish to redeem this tip.'))){ | |||
There was a problem hiding this comment.
Expected space(s) after "if". (keyword-spacing)
Missing space before opening brace. (space-before-blocks)
| @@ -45,7 +45,9 @@ window.onload = function() { | |||
| if (document.web3network != document.network) { | |||
| _alert({ message: gettext('You are not on the right web3 network. Please switch to ') + document.network }, 'error'); | |||
| } else { | |||
| $('#forwarding_address').val(web3.eth.coinbase); | |||
| if(!$('#forwarding_address').val()){ | |||
There was a problem hiding this comment.
Expected space(s) after "if". (keyword-spacing)
Unexpected if as the only statement in an else block. (no-lonely-if)
Missing space before opening brace. (space-before-blocks)
| @@ -82,6 +84,10 @@ $(document).ready(function() { | |||
| unloading_button($(this)); | |||
| return; | |||
| } | |||
| if(!confirm(gettext('Please confirm that ' + forwarding_address + ' is the address for which you wish to redeem this tip.'))){ | |||
There was a problem hiding this comment.
Expected space(s) after "if". (keyword-spacing)
Missing space before opening brace. (space-before-blocks)
Codecov Report
@@ Coverage Diff @@
## master #2728 +/- ##
=======================================
Coverage 29.91% 29.91%
=======================================
Files 163 163
Lines 13062 13062
Branches 1747 1747
=======================================
Hits 3908 3908
Misses 9030 9030
Partials 124 124Continue to review full report at Codecov.
|
Description
We had a user who accidently redeemed their ETH to the wrong address. In order to prevent user error in this vein in the future, we want to:
Checklist
Affected core subsystem(s)
tip/kudos
Testing
tested it
Refers/Fixes
email bug report