Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix travis tests #2724

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Fix travis tests #2724

merged 1 commit into from
Nov 8, 2018

Conversation

pinkiebell
Copy link
Contributor

@pinkiebell pinkiebell commented Nov 7, 2018 •
edited
Loading

Fixes #2678

stickler-ci
stickler-ci reviewed Nov 7, 2018
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
stickler-ci
stickler-ci reviewed Nov 7, 2018
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
stickler-ci
stickler-ci reviewed Nov 7, 2018
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@pinkiebell pinkiebell changed the title travis test Fix travis tests Nov 7, 2018
@pinkiebell
Copy link
Contributor Author

@mbeacom
Seems like the GeoIP Entries changed, I removed the city from the test set in case it happens again.
Quick merge?

owocki
owocki approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@owocki owocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbeacom mbeacom merged commit f1a2155 into gitcoinco:master Nov 8, 2018
@mbeacom
Copy link
Contributor

mbeacom commented Nov 8, 2018

@pinkiebell Thanks!

@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.30000 ETH (64.98 USD @ $216.6/ETH) has been granted to @pinkiebell for this issue from @owocki. ⚡️

The sender had the following public comments:

Thanks for being a great contrib!

Nice work @pinkiebell! Your tip has automatically been deposited in the ETH address we have on file.

@pinkiebell pinkiebell deleted the ci/travis branch January 3, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stickler-ci stickler-ci stickler-ci left review comments

@owocki owocki owocki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pinkiebell @mbeacom @gitcoinbot @owocki @stickler-ci