Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds 10 more kudos to the site #2698

Merged
merged 2 commits into from
Nov 6, 2018
Merged

adds 10 more kudos to the site #2698

merged 2 commits into from
Nov 6, 2018

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Nov 5, 2018

adds 10 more kudos to the site

@@ -1880,5 +1880,108 @@
- cryptography
- math
image: zk_snarks.svg

- name: creative_cat
description: Are you a creative cat? Are you always getting new, creative, ideas out to your team? Then this kudos is for you.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[error] line too long (130 > 80 characters) (line-length)

description: Are you a creative cat? Are you always getting new, creative, ideas out to your team? Then this kudos is for you.
priceFinney: 2
numClonesAllowed: 100
tags:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[error] trailing spaces (trailing-spaces)

- soft skills
image: creative_cat.svg
- name: firedog
description: This is fine.. Everything is fine. Know someone who's cool under pressure? Then this kudos is for them!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[error] line too long (120 > 80 characters) (line-length)

- memes
image: firedog.svg
- name: Octo-kitteh
description: Know someone who's a pro at git? Know someone who's such an efficient worker that they've probably got eight handes? This kudos is for htem.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[error] line too long (157 > 80 characters) (line-length)

description: Know someone who's a pro at git? Know someone who's such an efficient worker that they've probably got eight handes? This kudos is for htem.
priceFinney: 2
numClonesAllowed: 100
tags:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[error] trailing spaces (trailing-spaces)

description: Got someone in your life who is extremely pragmatic? This kudos is for them.
priceFinney: 2
numClonesAllowed: 100
tags:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[error] trailing spaces (trailing-spaces)

- compliments
image: pragmatic.svg
- name: scarlet_letter
description: Did someone you know do something awful, like send a Kudos to themselves? Then send them this Scarlet Letter Kudos

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[error] line too long (129 > 80 characters) (line-length)

description: Did someone you know do something awful, like send a Kudos to themselves? Then send them this Scarlet Letter Kudos
priceFinney: 2
numClonesAllowed: 1000
tags:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[error] trailing spaces (trailing-spaces)

description: This one is just for fun and appreciation of steampunk artwork
priceFinney: 2
numClonesAllowed: 100
tags:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[error] trailing spaces (trailing-spaces)

description: No one can say hello to another contributor like this alien Kudos
priceFinney: 2
numClonesAllowed: 100
tags:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[error] trailing spaces (trailing-spaces)

@mbeacom mbeacom added Gitcoin Kudos Gitcoin Kudos and removed in progress labels Nov 6, 2018
mbeacom
mbeacom previously approved these changes Nov 6, 2018
Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - Should we squash/svgo these kudos svgs @owocki ?

@jasonrhaas
Copy link
Contributor

For the new kudos, need to make sure we:

  • Compress SVG files using svgo --disable=removeViewBox
  • Update kudos.yaml in the kudos-badges repo (need to be moved over from private to public)
  • Mint kudos on chain
  • Kudos should sync automatically via the cron

@owocki
Copy link
Contributor Author

owocki commented Nov 6, 2018

wrestling with some dependancies to install svgo now...

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #2698 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2698   +/-   ##
=======================================
  Coverage   29.93%   29.93%           
=======================================
  Files         162      162           
  Lines       13052    13052           
  Branches     1743     1743           
=======================================
  Hits         3907     3907           
  Misses       9021     9021           
  Partials      124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d0b3c...a5e5627. Read the comment docs.

@mbeacom
Copy link
Contributor

mbeacom commented Nov 6, 2018

I ran svgo against the images/kudos directory @owocki

@owocki
Copy link
Contributor Author

owocki commented Nov 6, 2018

thanks! brew wasnt playing nice on this

@owocki owocki merged commit 2e6d510 into master Nov 6, 2018
@mbeacom mbeacom deleted the kevin/more_kudos branch November 6, 2018 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gitcoin Kudos Gitcoin Kudos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants