dupe profile cleanup part 2 #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Nov 5, 2018
| profile.handle = profile.handle.replace('@', '') | ||
| profile.save() | ||
|
|
||
| dupes = Profile.objects.exclude(handle=None).annotate(handle_lower=Lower("handle")).values('handle_lower').annotate(handle_lower_count=Count('handle_lower')).filter(handle_lower_count__gt=1) |
There was a problem hiding this comment.
E501 line too long (198 > 120 characters)
|
note: even better than cleaning up duplicate profiles would be to figure out how/why the |
Codecov Report
@@ Coverage Diff @@
## master #2696 +/- ##
=========================================
- Coverage 29.93% 29.9% -0.03%
=========================================
Files 162 162
Lines 13052 13064 +12
Branches 1743 1745 +2
=========================================
Hits 3907 3907
- Misses 9021 9033 +12
Partials 124 124
Continue to review full report at Codecov.
|
mbeacom
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
duplicate profiles, but now also handles:
Checklist
Affected core subsystem(s)
Testing
tested:
kennethashley
market protocol
pelsasser
Refers/Fixes
self