PR@2473: Add new background pattern category "wallpaper" #2689
Conversation
| @@ -1,5 +1,6 @@ | |||
| let openSection; | |||
| const layers = [ | |||
| 'Wallpaper', | |||
There was a problem hiding this comment.
Expected indentation of 2 spaces but found 1 tab. (indent)
| @@ -204,6 +205,7 @@ function setOption(option, value, target) { | |||
| case 'Nose': | |||
| case 'Ears': | |||
| case 'Mouth': | |||
| case 'Wallpaper': | |||
There was a problem hiding this comment.
Expected indentation of 4 spaces but found 1 tab. (indent)
| }, { | ||
| 'name': 'Wallpaper', | ||
| 'title': 'Pick some swag for your back', | ||
| 'options': ('anchors','jigsaw') |
app/avatar/utils.py
Outdated
| 'title': 'Pick some swag for your back', | ||
| 'options': ('anchors','jigsaw') | ||
| } | ||
| ], |
There was a problem hiding this comment.
E122 continuation line missing indentation or outdented
There was a problem hiding this comment.
@kuhnchris could you address the lint comments + run svgo to compress the svg + show a demo of the added wallpaper :)
|
also need to resolve the merge conflicts |
|
Yeah I'll take care of that ASAP, thanks for pointing it out! |
|
|
|
looking good! |
Codecov Report
@@ Coverage Diff @@
## master #2689 +/- ##
==========================================
- Coverage 29.89% 29.88% -0.01%
==========================================
Files 162 162
Lines 13050 13052 +2
Branches 1742 1743 +1
==========================================
Hits 3901 3901
- Misses 9025 9027 +2
Partials 124 124
Continue to review full report at Codecov.
|
|
Thanks @thelostone-mc for fixing that! |
|
@kuhnchris i wonder what i'm doing wrong with the new assets i added ... |
|
Wallpapers are a very... special thing. SVG has some kind of viewport defined at times, we need to check what you background did and check that one |
|
@kuhnchris here is a SVG i commited : https://github.com/gitcoinco/web/blob/master/app/assets/v2/images/avatar/Wallpaper/gears.svg there are others in the same directory as it what are the specs of the viewport i should set? |
|
Hi there, I never figured that out aswell, but it seems to vary wildly between template and display in avatar builder, hence my request if we could make a unified system that uses the same components instead of squashing them. What focus do you want @owocki : rewriting the avatar generation or fixing those SVGs? I think that the problems only continue to grow with the current system... |
|
per convo on slack, @kuhnchris is gonna submit a short term fix now and we'll break the larger scope into another ticket |
Description
Adds new background pattern category
Checklist
Affected core subsystem(s)
dashboard
Testing
done
Refers/Fixes
Fixes #2473