-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kudos : add share button #2688
kudos : add share button #2688
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2688 +/- ##
=======================================
Coverage 29.97% 29.97%
=======================================
Files 162 162
Lines 13015 13015
Branches 1741 1741
=======================================
Hits 3901 3901
Misses 8990 8990
Partials 124 124 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is AMAZING and really needed
Don't know how complicate is right now but should be nice to also close the modal clicking outside. |
@octavioamu Ah I meant to do that. Added it in now :) |
Maybe we can merge this one and add the click outside to close later |
@octavioamu I got that done that day. Forgot to tell you about it 😅 @mbeacom Ah Sorry about forgetting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAy
Description
@octavioamu could you help out with these
share.html
file for now as I'm not sure which we way to goChecklist
Fixes:
#2666 and #2617