Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kudos : add share button #2688

Merged
merged 5 commits into from
Nov 12, 2018
Merged

kudos : add share button #2688

merged 5 commits into from
Nov 12, 2018

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Nov 4, 2018

Description

untitled

@octavioamu could you help out with these

  • Adding custom message + image for share facebook URL. (not sure how to configure the URL)
  • Do i use scss / css ? I've left in within the share.html file for now as I'm not sure which we way to go
Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Fixes:

#2666 and #2617

@thelostone-mc thelostone-mc self-assigned this Nov 4, 2018
@thelostone-mc thelostone-mc added frontend This needs frontend expertise. needs review Gitcoin Kudos Gitcoin Kudos labels Nov 4, 2018
@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #2688 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2688   +/-   ##
=======================================
  Coverage   29.97%   29.97%           
=======================================
  Files         162      162           
  Lines       13015    13015           
  Branches     1741     1741           
=======================================
  Hits         3901     3901           
  Misses       8990     8990           
  Partials      124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d2a32...d1bfb1f. Read the comment docs.

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is AMAZING and really needed

app/kudos/templates/share.html Outdated Show resolved Hide resolved
app/kudos/templates/share.html Outdated Show resolved Hide resolved
app/kudos/templates/share.html Outdated Show resolved Hide resolved
@octavioamu
Copy link
Contributor

Don't know how complicate is right now but should be nice to also close the modal clicking outside.

octavioamu
octavioamu previously approved these changes Nov 5, 2018
@thelostone-mc
Copy link
Member Author

Don't know how complicate is right now but should be nice to also close the modal clicking outside.

@octavioamu Ah I meant to do that. Added it in now :)

@octavioamu
Copy link
Contributor

Maybe we can merge this one and add the click outside to close later

app/kudos/templates/share.html Show resolved Hide resolved
app/kudos/templates/share.html Outdated Show resolved Hide resolved
app/kudos/templates/share.html Outdated Show resolved Hide resolved
app/kudos/templates/share.html Outdated Show resolved Hide resolved
app/kudos/templates/kudos_details.html Outdated Show resolved Hide resolved
@thelostone-mc
Copy link
Member Author

Maybe we can merge this one and add the click outside to close later

@octavioamu I got that done that day. Forgot to tell you about it 😅

@mbeacom Ah Sorry about forgetting the trans tag. 😅
goes to a corner and weeps in embarrassment

@thelostone-mc thelostone-mc changed the title [WIP] kudos : add share button kudos : add share button Nov 7, 2018
Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAy

@octavioamu octavioamu merged commit a1f07d1 into gitcoinco:master Nov 12, 2018
@thelostone-mc thelostone-mc deleted the tweet branch November 20, 2018 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise. Gitcoin Kudos Gitcoin Kudos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants