Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix never expires #2676

Merged
merged 3 commits into from
Nov 12, 2018
Merged

Fix never expires #2676

merged 3 commits into from
Nov 12, 2018

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Nov 3, 2018

Description

This fixes the estimate expiration when user choose "Never"

In bounty detail:
image

In explorer:
image

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
Testing
Refers/Fixes

Fixes: #2538

app/assets/v2/js/pages/bounty_details.js Outdated Show resolved Hide resolved
app/assets/v2/js/shared.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 3, 2018

Codecov Report

Merging #2676 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2676   +/-   ##
=======================================
  Coverage   29.97%   29.97%           
=======================================
  Files         162      162           
  Lines       13016    13016           
  Branches     1741     1741           
=======================================
  Hits         3902     3902           
  Misses       8990     8990           
  Partials      124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0575da8...3d4fdf1. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY! will merge once freeze is relaxed :P

@SaptakS SaptakS merged commit 0d08313 into master Nov 12, 2018
@thelostone-mc thelostone-mc deleted the infinite-expire branch December 28, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a contributor, I'd like to see the correct time estimate on a Gitcoin Issue.
5 participants