Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locking mechanism to handle dupe gitcoinbot comments #2674

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Nov 2, 2018

Description

locking mechanism to handle dupe gitcoinbot submission

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

bounties

Testing

tested it by adding a time.sleep() to the sync_geth method

Refers/Fixes

#2488

@owocki owocki changed the title locking mechanism to handle dupe gitcoinbot submission locking mechanism to handle dupe gitcoinbot comments Nov 2, 2018
@codecov
Copy link

codecov bot commented Nov 2, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@0275e2b). Click here to learn what that means.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2674   +/-   ##
=========================================
  Coverage          ?   29.86%           
=========================================
  Files             ?      162           
  Lines             ?    13017           
  Branches          ?     1741           
=========================================
  Hits              ?     3888           
  Misses            ?     9005           
  Partials          ?      124
Impacted Files Coverage Δ
app/dashboard/utils.py 35.55% <10%> (ø)
app/app/settings.py 80.16% <100%> (ø)
app/app/utils.py 22.42% <14.28%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0275e2b...72d2860. Read the comment docs.

@owocki owocki force-pushed the kevin/semaphor_to_handle_dupe_gitcoinbot_submission branch from 2314ead to 72d2860 Compare November 2, 2018 22:39
Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owocki This LGTM - Does this seem to work fine with Python 3.7?

My main hangup is that redis-semaphore was last updated in December 2016 and doesn't seem to have a whole lot of traction as far as stars/forks go.

I'm not saying we shouldn't merge this - just an ongoing support question. Did you happen to check out https://github.com/vaidik/sherlock ?

@owocki
Copy link
Contributor Author

owocki commented Nov 3, 2018

yes i tested with python 3.7 and it worked fine.

i agree sherlock looks more fully featured, but it also hasn't had an update in ~ 7 months

@owocki
Copy link
Contributor Author

owocki commented Nov 5, 2018

#2695

@owocki owocki merged commit 1608344 into master Nov 5, 2018
@mbeacom mbeacom deleted the kevin/semaphor_to_handle_dupe_gitcoinbot_submission branch November 7, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants