Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile fixes #2661

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Profile fixes #2661

merged 2 commits into from
Nov 5, 2018

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Nov 1, 2018

Description

The kudos profile filter need refactor to handle the relation since token_id is null in kudos transfer

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
Testing
Refers/Fixes

@owocki
Copy link
Contributor

owocki commented Nov 1, 2018

#2662

@codecov
Copy link

codecov bot commented Nov 1, 2018

Codecov Report

Merging #2661 into master will increase coverage by 0.35%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2661      +/-   ##
==========================================
+ Coverage   29.92%   30.27%   +0.35%     
==========================================
  Files         162      162              
  Lines       13003    13242     +239     
  Branches     1741     1845     +104     
==========================================
+ Hits         3891     4009     +118     
- Misses       8988     9101     +113     
- Partials      124      132       +8
Impacted Files Coverage Δ
app/dashboard/models.py 53.25% <ø> (+0.95%) ⬆️
app/dashboard/views.py 14.22% <0%> (+1.29%) ⬆️
app/kudos/views.py 28.76% <0%> (+0.13%) ⬆️
app/kudos/models.py 52.8% <0%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fea229...7baa380. Read the comment docs.

app/dashboard/models.py Outdated Show resolved Hide resolved
app/dashboard/models.py Outdated Show resolved Hide resolved
app/dashboard/models.py Outdated Show resolved Hide resolved
app/kudos/models.py Outdated Show resolved Hide resolved
app/kudos/models.py Outdated Show resolved Hide resolved
app/kudos/models.py Outdated Show resolved Hide resolved
app/kudos/models.py Outdated Show resolved Hide resolved
app/kudos/views.py Outdated Show resolved Hide resolved
@octavioamu octavioamu changed the title [WIP] Profile fixes Profile fixes Nov 1, 2018
@octavioamu octavioamu requested a review from owocki November 1, 2018 15:08
@octavioamu
Copy link
Contributor Author

@owocki tell me something about this one when you have a chance

@octavioamu octavioamu requested a review from mbeacom November 5, 2018 15:44
@owocki owocki merged commit 3f3165b into master Nov 5, 2018
@thelostone-mc thelostone-mc deleted the profile-fixes branch December 28, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants