-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile fixes #2661
Merged
Merged
Profile fixes #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2661 +/- ##
==========================================
+ Coverage 29.92% 30.27% +0.35%
==========================================
Files 162 162
Lines 13003 13242 +239
Branches 1741 1845 +104
==========================================
+ Hits 3891 4009 +118
- Misses 8988 9101 +113
- Partials 124 132 +8
Continue to review full report at Codecov.
|
stickler-ci
reviewed
Nov 1, 2018
octavioamu
force-pushed
the
profile-fixes
branch
from
November 1, 2018 15:00
8ac8297
to
7baa380
Compare
@owocki tell me something about this one when you have a chance |
owocki
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix show same id card (keeps duplicating comments)fixed in refactors kudos data profile so the view/data/query is comprehensible #2662The kudos profile filter need refactor to handle the relation since token_id is null in kudos transfer
Checklist
Affected core subsystem(s)
Testing
Refers/Fixes