Adjust lazy_load_kudos to catch nonexistent profile #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbeacom
added
bug
|
LGTM , tested in my local |
octavioamu
reviewed
Oct 31, 2018
| @@ -1202,22 +1202,25 @@ def profile(request, handle): | |||
| @csrf_exempt | |||
| def lazy_load_kudos(request): | |||
| page = request.POST.get('page', 1) | |||
| address = request.POST.get('address') | |||
| context = {} | |||
| datarequest = request.POST.get('request') | |||
| order_by = request.GET.get('order_by', '-modified_on') | |||
There was a problem hiding this comment.
looks like the order was removed from the front end so if we are not going to have it there is not need to have it in the request
There was a problem hiding this comment.
I'll remove it in a follow up. Thanks for the heads up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to resolve the exception encountered in: #2655 when attempting to query for a profile that doesn't exist in
lazy_load_kudosChecklist
Testing
Local
Refers/Fixes
Fix #2655