-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for tx's running out of gas #2656
Conversation
Seeing an out of gas error when using this on rinkeby |
Codecov Report
@@ Coverage Diff @@
## master #2656 +/- ##
==========================================
- Coverage 29.94% 29.93% -0.02%
==========================================
Files 162 162
Lines 12955 13007 +52
Branches 1737 1750 +13
==========================================
+ Hits 3880 3894 +14
- Misses 8951 8987 +36
- Partials 124 126 +2
Continue to review full report at Codecov.
|
@mbeacom this was a Kudos Indirect Send right? |
Doesn't this line https://github.com/gitcoinco/web/blob/master/app/assets/v2/js/pages/kudos_send.js#L508 already account for the Kudos gasLimit? It seems like we are sending the gas money twice. I suppose it's better to have extra gas in there anyway. We just need to make sure that we return the extra gas money leftover. |
gas limit fix. this is a fix for
#2586
it needs to be tested before deployment. i can't do that currently bc i have bad internet..