Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for tx's running out of gas #2656

Merged
merged 4 commits into from
Nov 1, 2018
Merged

fix for tx's running out of gas #2656

merged 4 commits into from
Nov 1, 2018

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Oct 31, 2018

gas limit fix. this is a fix for

#2586

it needs to be tested before deployment. i can't do that currently bc i have bad internet..

@mbeacom
Copy link
Contributor

mbeacom commented Oct 31, 2018

Seeing an out of gas error when using this on rinkeby

@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #2656 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2656      +/-   ##
==========================================
- Coverage   29.94%   29.93%   -0.02%     
==========================================
  Files         162      162              
  Lines       12955    13007      +52     
  Branches     1737     1750      +13     
==========================================
+ Hits         3880     3894      +14     
- Misses       8951     8987      +36     
- Partials      124      126       +2
Impacted Files Coverage Δ
app/kudos/views.py 26.56% <0%> (-2.2%) ⬇️
app/retail/views.py 31.73% <0%> (+1.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c99cdc...7a274ed. Read the comment docs.

@jasonrhaas
Copy link
Contributor

Seeing an out of gas error when using this on rinkeby

@mbeacom this was a Kudos Indirect Send right?

@owocki owocki changed the title WIP - fix for tx's running out of gas fix for tx's running out of gas Nov 1, 2018
@owocki
Copy link
Contributor Author

owocki commented Nov 1, 2018

@mbeacom f93b834 should fix that

@owocki owocki merged commit 7a274ed into master Nov 1, 2018
@jasonrhaas
Copy link
Contributor

Doesn't this line https://github.com/gitcoinco/web/blob/master/app/assets/v2/js/pages/kudos_send.js#L508

already account for the Kudos gasLimit? It seems like we are sending the gas money twice. I suppose it's better to have extra gas in there anyway. We just need to make sure that we return the extra gas money leftover.

@thelostone-mc thelostone-mc deleted the kevin/gas-limit-fix branch December 28, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gitcoin Kudos Gitcoin Kudos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants