Create kudos in feed #2576
Merged
Create kudos in feed #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Oct 30, 2018
3 tasks
|
@octavioamu the code LGTM -- did you test!? the linter/build is failing |
|
@owocki is not finished I will come back to this one today |
Codecov Report
@@ Coverage Diff @@
## master #2576 +/- ##
==========================================
+ Coverage 29.96% 30.73% +0.76%
==========================================
Files 162 162
Lines 13027 13507 +480
Branches 1741 1927 +186
==========================================
+ Hits 3904 4151 +247
- Misses 8999 9243 +244
+ Partials 124 113 -11
Continue to review full report at Codecov.
|
stickler-ci
reviewed
Nov 2, 2018
app/kudos/views.py
Outdated
| @@ -283,7 +262,13 @@ def send_2(request): | |||
| This form is filled out before the 'send' button is clicked. | |||
|
|
|||
| """ | |||
| if not request.user.is_authenticated or request.user.is_authenticated and not getattr(request.user, 'profile', None): | |||
There was a problem hiding this comment.
E501 line too long (121 > 120 characters)
octavioamu
force-pushed
the
kudos-feed
branch
from
4ddaf7b to
520e75d
Compare
stickler-ci
reviewed
Nov 2, 2018
app/kudos/views.py
Outdated
| @@ -450,8 +487,8 @@ def receive(request, key, txid, network): | |||
|
|
|||
| """ | |||
| these_kudos_transfers = KudosTransfer.objects.filter(web3_type='v3', txid=txid, network=network) | |||
| kudos_transfers = these_kudos_transfers.filter(metadata__reference_hash_for_receipient=key) | these_kudos_transfers.filter( | |||
| metadata__reference_hash_for_funder=key) | |||
| kudos_transfers = these_kudos_transfers.filter(metadata__reference_hash_for_receipient=key) | | |||
There was a problem hiding this comment.
Need to fix the syntax error here
There was a problem hiding this comment.
tried to fix the E501 line too long
app/kudos/views.py
Outdated
| kudos_transfers = these_kudos_transfers.filter(metadata__reference_hash_for_receipient=key) | these_kudos_transfers.filter( | ||
| metadata__reference_hash_for_funder=key) | ||
| kudos_transfers = these_kudos_transfers.filter(metadata__reference_hash_for_receipient=key) | | ||
| these_kudos_transfers.filter(metadata__reference_hash_for_funder=key) |
owocki
previously approved these changes
Nov 2, 2018
|
LGTM; @mbeacom ? |
This comment has been minimized.
This comment has been minimized.
mbeacom
suggested changes
Nov 3, 2018
There was a problem hiding this comment.
Should be good to go once the syntax error is fixed
Thanks @octavioamu
app/kudos/views.py
Outdated
| @@ -450,8 +487,8 @@ def receive(request, key, txid, network): | |||
|
|
|||
| """ | |||
| these_kudos_transfers = KudosTransfer.objects.filter(web3_type='v3', txid=txid, network=network) | |||
| kudos_transfers = these_kudos_transfers.filter(metadata__reference_hash_for_receipient=key) | these_kudos_transfers.filter( | |||
| metadata__reference_hash_for_funder=key) | |||
| kudos_transfers = these_kudos_transfers.filter(metadata__reference_hash_for_receipient=key) | | |||
There was a problem hiding this comment.
Need to fix the syntax error here
stickler-ci
reviewed
Nov 5, 2018
|
ok let me know when its finished |
octavioamu
force-pushed
the
kudos-feed
branch
from
9a84d19 to
5561d2c
Compare
|
YES! figured out how to do it, lol. Ready to merge @owocki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Affected core subsystem(s)
Testing
Refers/Fixes