Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sentry error log #2575

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Fix sentry error log #2575

merged 2 commits into from
Oct 31, 2018

Conversation

octavioamu
Copy link
Contributor

Description
Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
Testing
Refers/Fixes

Fixes: #2554

@octavioamu octavioamu changed the title fix sentry error log Fix sentry error log Oct 30, 2018

return JSON.parse('{"' + decodeURI(search).replace(/"/g, '\\"').replace(/&/g, '","').replace(/=/g, '":"') + '"}');
for (var i = 0; i < hashes.length; i++) {
hash = hashes[i].split('=');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected indentation of 4 spaces but found 6. (indent)

return JSON.parse('{"' + decodeURI(search).replace(/"/g, '\\"').replace(/&/g, '","').replace(/=/g, '":"') + '"}');
for (var i = 0; i < hashes.length; i++) {
hash = hashes[i].split('=');
myJson[hash[0]] = hash[1];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected indentation of 4 spaces but found 6. (indent)

@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

Merging #2575 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2575   +/-   ##
=======================================
  Coverage   30.01%   30.01%           
=======================================
  Files         162      162           
  Lines       12919    12919           
  Branches     1729     1729           
=======================================
  Hits         3878     3878           
  Misses       8919     8919           
  Partials      122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe2763...36d8527. Read the comment docs.

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 🎉

Thank you!
🚢

@mbeacom mbeacom added frontend This needs frontend expertise. Gitcoin Kudos Gitcoin Kudos labels Oct 30, 2018
@SaptakS SaptakS merged commit 6fe6fef into master Oct 31, 2018
@thelostone-mc thelostone-mc deleted the search-error branch December 28, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise. Gitcoin Kudos Gitcoin Kudos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KUDOS: SyntaxError: Unexpected token } in JSON at position 19
4 participants