New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates / adds kudos docs for public consumption #2566

Merged

owocki merged 4 commits into master from kevin/kudos-docs

Nov 5, 2018

Contributor

owocki commented Oct 30, 2018

updates / adds kudos docs, also moves the fresh_start script to a more descriptive name

owocki added 2 commits

October 30, 2018 08:55


          updates the kudos docs for public consumption

1dd629d


          adds kudos docs

f6a775c

owocki assigned octavioamu and mbeacom

mbeacom added the in progress label

owocki changed the title ~~updates / adds kudos docs~~ updates / adds kudos docs for public consumption

codecov bot commented Oct 30, 2018 •

edited

Loading

Codecov Report

Merging #2566 into master will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2566      +/-   ##
==========================================
+ Coverage   29.86%   30.04%   +0.18%     
==========================================
  Files         162      162              
  Lines       12983    12898      -85     
  Branches     1738     1723      -15     
==========================================
- Hits         3877     3875       -2     
+ Misses       8982     8901      -81     
+ Partials      124      122       -2

Impacted Files	Coverage Δ
app/dashboard/views.py	`12.82% <0%> (-0.11%)`	⬇️
app/marketing/views.py	`13.31% <0%> (ø)`	⬆️
app/app/urls.py	`86.95% <0%> (ø)`	⬆️
app/retail/emails.py	`21.13% <0%> (+0.28%)`	⬆️
app/dashboard/models.py	`52.84% <0%> (+0.55%)`	⬆️
app/kudos/views.py	`30.8% <0%> (+1.63%)`	⬆️
app/gas/utils.py	`38.46% <0%> (+3.07%)`	⬆️
app/dashboard/embed.py	`31.6% <0%> (+3.44%)`	⬆️
app/marketing/models.py	`64.67% <0%> (+4.37%)`	⬆️
...eting/management/commands/assemble_leaderboards.py	`85.71% <0%> (+5.2%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48fadf...a0273d8. Read the comment docs.

mbeacom previously approved these changes

View reviewed changes

Contributor

mbeacom left a comment

@owocki Think we should add this to Makefile as well? We could include it as an automatic provisioning step based on an envvar as well..? 🤔


          Add kudos documentation to doc pipeline

743d2e8

mbeacom dismissed their stale review via

743d2e8

November 1, 2018 13:06

stickler-ci reviewed

View reviewed changes

pydocmd.yml

@@ @@ -130,6 +130,20 @@ generate: @@
                   - gitcoinbot.views++
                 - healthcheck/healthchecks.md:
                   - healthcheck.healthchecks++
+                - kudos/admin.md:
+                  - kudos.admin++

stickler-ci Nov 1, 2018

[error] wrong indentation: expected 6 but found 4 (indentation)

pydocmd.yml

+                - kudos/admin.md:
+                  - kudos.admin++
+                - kudos/forms.md:
+                  - kudos.forms++

stickler-ci Nov 1, 2018

[error] wrong indentation: expected 6 but found 4 (indentation)

pydocmd.yml

+                - kudos/forms.md:
+                  - kudos.forms++
+                - kudos/helpers.md:
+                  - kudos.helpers++

stickler-ci Nov 1, 2018

[error] wrong indentation: expected 6 but found 4 (indentation)

pydocmd.yml

+                - kudos/helpers.md:
+                  - kudos.helpers++
+                - kudos/router.md:
+                  - kudos.router++

stickler-ci Nov 1, 2018

[error] wrong indentation: expected 6 but found 4 (indentation)

pydocmd.yml

+                - kudos/router.md:
+                  - kudos.router++
+                - kudos/models.md:
+                  - kudos.models++

stickler-ci Nov 1, 2018

[error] wrong indentation: expected 6 but found 4 (indentation)

pydocmd.yml

+                - kudos/models.md:
+                  - kudos.models++
+                - kudos/utils.md:
+                  - kudos.utils++

stickler-ci Nov 1, 2018

[error] wrong indentation: expected 6 but found 4 (indentation)

pydocmd.yml

+                - kudos/utils.md:
+                  - kudos.utils++
+                - kudos/views.md:
+                  - kudos.views++

stickler-ci Nov 1, 2018

[error] wrong indentation: expected 6 but found 4 (indentation)

pydocmd.yml

@@ @@ -286,6 +300,15 @@ pages: @@
                     - Admin: gitcoinbot/admin.md
                     - Models: gitcoinbot/models.md
                     - Views: gitcoinbot/views.md
+                  - Kudos:
+                    - Local Deployment: kudos_deploy >> docs/KUDOS.md

stickler-ci Nov 1, 2018

[error] wrong indentation: expected 8 but found 6 (indentation)

mbeacom approved these changes

View reviewed changes

Contributor

mbeacom left a comment

🚢


          Merge remote-tracking branch 'origin/master' into kevin/kudos-docs

a0273d8

owocki merged commit 7e9f634 into master

mbeacom removed the in progress label

thelostone-mc deleted the kevin/kudos-docs branch

December 28, 2018 20:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet