Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2529 - Fix broken URL in GitHub Pull Request Template #2533

Merged
merged 2 commits into from
Oct 28, 2018
Merged

#2529 - Fix broken URL in GitHub Pull Request Template #2533

merged 2 commits into from
Oct 28, 2018

Conversation

kuhnchris
Copy link
Contributor

Description

Fix the broken URL to contribution document in pull request template.

Checklist

[X] Template change - no code modification(s)

Affected core subsystem(s)

github

Testing

Create PR, see change.

Refers/Fixes

Fixes: #2529 - #2529

Fix the broken URL to contribution document in pull request template.

Fixes: #2529 - #2529
@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #2533 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2533   +/-   ##
=======================================
  Coverage   29.08%   29.08%           
=======================================
  Files         148      148           
  Lines       11929    11929           
  Branches     1616     1616           
=======================================
  Hits         3469     3469           
  Misses       8342     8342           
  Partials      118      118

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3178739...27943b0. Read the comment docs.

@@ -2,7 +2,7 @@
Thank you for your pull request. Please provide a description above and review
the requirements below.

Contributors guide: https://github.com/gitcoinco/web/blob/contributing/CONTRIBUTING.md
Contributors guide: https://github.com/gitcoinco/web/blob/master/docs/CONTRIBUTING.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this to link to: https://docs.gitcoin.co/mk_contributors/ ?

Additional URL change
@kuhnchris
Copy link
Contributor Author

as requested by @mbeacom - updated to the new url

@thelostone-mc thelostone-mc added doc bug This is something that isn't working as intended. labels Oct 28, 2018
@thelostone-mc thelostone-mc merged commit 774b996 into gitcoinco:master Oct 28, 2018
@kuhnchris kuhnchris deleted the patch-1 branch October 28, 2018 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is something that isn't working as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants