cancelSubscription contract functionality and minor fixes to index.html and detail.html #2501
Conversation
docker-compose.yml
Outdated
| pgweb: | ||
| image: sosedoff/pgweb | ||
| environment: | ||
| - DATABASE_URL=postgres://postgres:postgres@db:5432?sslmode=disable |
There was a problem hiding this comment.
[error] wrong indentation: expected 6 but found 8 (indentation)
docker-compose.yml
Outdated
| environment: | ||
| - DATABASE_URL=postgres://postgres:postgres@db:5432?sslmode=disable | ||
| links: | ||
| - db |
There was a problem hiding this comment.
[error] wrong indentation: expected 6 but found 8 (indentation)
docker-compose.yml
Outdated
| links: | ||
| - db | ||
| ports: | ||
| - "8081:8081" |
There was a problem hiding this comment.
[error] wrong indentation: expected 6 but found 8 (indentation)
Codecov Report
@@ Coverage Diff @@
## grants #2501 +/- ##
==========================================
+ Coverage 29.57% 29.73% +0.16%
==========================================
Files 155 154 -1
Lines 12306 12116 -190
Branches 1657 1618 -39
==========================================
- Hits 3639 3603 -36
+ Misses 8546 8395 -151
+ Partials 121 118 -3
Continue to review full report at Codecov.
|
|
@captnseagraves Updating this PR to use |
app/assets/v2/js/shared.js
Outdated
| @@ -712,7 +712,8 @@ var trigger_primary_form_web3_hooks = function() { | |||
|
|
|||
| if ($('#primary_form').length) { | |||
| var is_zero_balance_not_okay = document.location.href.indexOf('/faucet') == -1; | |||
| var unlock_metamask_error = web3.eth.coinbase ? web3.eth.coinbase : web3.eth.getCoinbase(); | |||
| // var unlock_metamask_error = web3.eth.coinbase ? web3.eth.coinbase : web3.eth.getCoinbase(); | |||
| var unlock_metamask_error = '0x0000000000000000000000000000000000000000'; | |||
There was a problem hiding this comment.
Do we need to revisit this @SaptakS @captnseagraves ?
There was a problem hiding this comment.
yes, we do. I think creating a solution for web3.js 1.0 in grants that is imported along with the needed functions will probably be best to not mess with bounties functionality. I added this work-around to keep moving. Happy to work on this issue today.
There was a problem hiding this comment.
Do I need to change this in order to get the rest of the changes merged in?
|
@mbeacom whoops! thank you! 🙏 |
| @@ -151,6 +151,8 @@ <h1 class="grant__title font-title-xl mb-4"> | |||
| </div> | |||
| </div> | |||
|
|
|||
| <div class="update-milestone"> | |||
|
|
|||
| <div class="container mt-4"> | |||
There was a problem hiding this comment.
@captnseagraves could we indent this by 1 ?
|
@mbeacom with comments adressed, is this good to merge? |
|
@mbeacom @thelostone-mc @SaptakS Any other comments on this PR? Going to merge today if nothing else. |
cancelSubscription contract functionality and minor fixes to index.html and detail.html