Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds metamask check in grant form #2487

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Conversation

SaptakS
Copy link
Contributor

@SaptakS SaptakS commented Oct 18, 2018

Description

Adds metamask check in grant creation form with web3 version check

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
Testing
Refers/Fixes

Refs: #2444

@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #2487 into grants will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           grants    #2487      +/-   ##
==========================================
- Coverage   29.72%   29.67%   -0.05%     
==========================================
  Files         154      154              
  Lines       12113    12113              
  Branches     1618     1618              
==========================================
- Hits         3601     3595       -6     
- Misses       8394     8400       +6     
  Partials      118      118
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6156d98...9d1b0b9. Read the comment docs.

@mbeacom mbeacom added frontend This needs frontend expertise. grants labels Oct 18, 2018
@mbeacom mbeacom merged commit 99436c9 into gitcoinco:grants Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants