Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grants - Require login on some views and help_text on all model attrs #2485

Merged
merged 2 commits into from
Oct 17, 2018

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Oct 17, 2018

Description

The goal of this PR is to introduce i18n compliant help_text on all model fields and require login for profile specific views: new, profile, milestones, fund, and subscription_cancel

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

grants, subscriptions, models, views

Testing

Locall

@mbeacom mbeacom added enhancement This is a feature to be enhanced or improved. backend This needs backend expertise. grants labels Oct 17, 2018
@mbeacom mbeacom self-assigned this Oct 17, 2018
@mbeacom mbeacom changed the base branch from master to grants October 17, 2018 17:16
@mbeacom mbeacom merged commit f7b94f2 into grants Oct 17, 2018
@mbeacom mbeacom deleted the grants-login-required-helper-text branch October 17, 2018 17:25
@codecov
Copy link

codecov bot commented Oct 17, 2018

Codecov Report

Merging #2485 into grants will decrease coverage by 0.04%.
The diff coverage is 92.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           grants    #2485      +/-   ##
==========================================
- Coverage   29.71%   29.67%   -0.05%     
==========================================
  Files         154      154              
  Lines       12104    12108       +4     
  Branches     1616     1617       +1     
==========================================
- Hits         3597     3593       -4     
- Misses       8389     8397       +8     
  Partials      118      118
Impacted Files Coverage Δ
app/grants/models.py 93.22% <100%> (ø) ⬆️
app/grants/views.py 22.22% <100%> (+0.85%) ⬆️
app/dashboard/views.py 13.04% <25%> (+0.06%) ⬆️
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38d5f52...5d38ce4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This needs backend expertise. enhancement This is a feature to be enhanced or improved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant