grants/profile : add txn history template #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set up route + view + empty template - css clean up + indent fix - renamed grants/grant_card -> grants/card - split up card css to it's own file
- UI template with be hardcoded - minimal refactoring
stickler-ci
reviewed
Oct 14, 2018
app/grants/views.py
Outdated
| history = [ | ||
| { | ||
| 'date': '16 Mar', | ||
| 'value_true' : 1.0, |
app/grants/views.py
Outdated
| { | ||
| 'date': '16 Mar', | ||
| 'value_true' : 1.0, | ||
| 'token_name' : 'ETH', |
app/grants/views.py
Outdated
| 'date': '16 Mar', | ||
| 'value_true' : 1.0, | ||
| 'token_name' : 'ETH', | ||
| 'frequency' : 'days', |
app/grants/views.py
Outdated
| 'value_true' : 1.0, | ||
| 'token_name' : 'ETH', | ||
| 'frequency' : 'days', | ||
| 'value_in_usdt_now' : 80, |
app/grants/views.py
Outdated
| }, | ||
| { | ||
| 'date': '24 April', | ||
| 'value_true' : 90, |
app/grants/views.py
Outdated
| { | ||
| 'date': '24 April', | ||
| 'value_true' : 90, | ||
| 'token_name' : 'DAI', |
app/grants/views.py
Outdated
| 'date': '24 April', | ||
| 'value_true' : 90, | ||
| 'token_name' : 'DAI', | ||
| 'frequency' : 'months', |
app/grants/views.py
Outdated
| 'value_true' : 90, | ||
| 'token_name' : 'DAI', | ||
| 'frequency' : 'months', | ||
| 'value_in_usdt_now' : 90, |
Codecov Report
@@ Coverage Diff @@
## grants #2465 +/- ##
==========================================
+ Coverage 29.62% 29.65% +0.03%
==========================================
Files 154 154
Lines 12115 12021 -94
Branches 1649 1607 -42
==========================================
- Hits 3589 3565 -24
+ Misses 8400 8338 -62
+ Partials 126 118 -8
Continue to review full report at Codecov.
|
mbeacom
approved these changes
Oct 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
grants/profile: added txn history section …
Refers/Fixes
#2019