Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Anonymous - Refactoring GatteJyoti's commit and pushing. #2464

Merged
merged 1 commit into from
Oct 14, 2018

Conversation

Anish-Agnihotri
Copy link
Contributor

Description

This PR aims to resolve issue #2273 that involved hiding funder details if they chose to be anonymous. It does so by using a simple check to see if the result.bounty_owner_name == 'Anonymous', and, if so - it simply hides the elements that need to be hidden.

This was completed 100% by @GatteJyoti, although they went MIA post review so I've restructured the code according to review and PR'd.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

UI subsystem is the only one that has been changed.

Testing

I assume that this has been tested beforehand, but I've also run it on a local machine to confirm that it works.

Refers/Fixes

PR fixes issue #2273.

@codecov
Copy link

codecov bot commented Oct 14, 2018

Codecov Report

Merging #2464 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2464   +/-   ##
=======================================
  Coverage   29.27%   29.27%           
=======================================
  Files         147      147           
  Lines       11872    11872           
  Branches     1605     1605           
=======================================
  Hits         3475     3475           
  Misses       8279     8279           
  Partials      118      118

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef9f7ee...4aaefb5. Read the comment docs.

@thelostone-mc thelostone-mc mentioned this pull request Oct 14, 2018
3 tasks
@thelostone-mc thelostone-mc added frontend This needs frontend expertise. enhancement This is a feature to be enhanced or improved. labels Oct 14, 2018
@thelostone-mc thelostone-mc merged commit 403942a into gitcoinco:master Oct 14, 2018
@thelostone-mc
Copy link
Member

Thanks man ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is a feature to be enhanced or improved. frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants