Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bounty template layout adjustments #2457

Merged
merged 1 commit into from
Oct 20, 2018
Merged

bounty template layout adjustments #2457

merged 1 commit into from
Oct 20, 2018

Conversation

pinkiebell
Copy link
Contributor

Description

Adjusts the layout for bounty rows and refactor the template a bit.

@codecov
Copy link

codecov bot commented Oct 13, 2018

Codecov Report

Merging #2457 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2457      +/-   ##
==========================================
- Coverage   29.27%   29.22%   -0.06%     
==========================================
  Files         147      147              
  Lines       11872    11872              
  Branches     1605     1605              
==========================================
- Hits         3475     3469       -6     
- Misses       8279     8285       +6     
  Partials      118      118
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bbe12e...437bd3d. Read the comment docs.

@thelostone-mc
Copy link
Member

@pinkiebell could you throw in a before and after screenshot ?

@thelostone-mc thelostone-mc self-requested a review October 15, 2018 03:45
@pinkiebell
Copy link
Contributor Author

I rebased & pushed another version of this.
Layout is close to the original except for the removed background color and the added flex-wrap.
Before that change, there was a possibility that the funding tags got clipped' off.

Before
localhost_8000_explorer_network mainnet order_by null

After
localhost_8000_explorer_network mainnet order_by null 1
localhost_8000_explorer_network mainnet order_by null 2

@thelostone-mc thelostone-mc merged commit 47f966d into gitcoinco:master Oct 20, 2018
@pinkiebell pinkiebell deleted the css/bounty branch November 6, 2018 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants