Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A sample Adobe Illustrator file to help artists get started #2433

Merged
merged 15 commits into from
Nov 5, 2018

Conversation

Dgilliams
Copy link
Contributor

Description

A starting point for beginner artists with prenamed layers and artboard dimensions set.
layers

The overlays from the design guide are included as hidden layers with partial opacity. Toggle the visibility of these with the eyeball next to their layer name.
grid_sections

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

none

Testing

none

Refers/Fixes

open to suggestion!

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dgilliams This is awesome! Would you mind moving the file to a new subdirectory in avatar/ like design or something similar? templates are specifically Django templates that are processed by the templating engine. We might even want to consider moving this to a subdirectory in the docs/ directory. 🤔 Additionally, can you PR the same on https://github.com/gitcoinco/creative ?

@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #2433 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2433      +/-   ##
==========================================
- Coverage   29.22%   29.13%   -0.09%     
==========================================
  Files         147      148       +1     
  Lines       11872    11929      +57     
  Branches     1605     1616      +11     
==========================================
+ Hits         3469     3475       +6     
- Misses       8285     8336      +51     
  Partials      118      118
Impacted Files Coverage Δ
app/avatar/utils.py 18.43% <ø> (ø) ⬆️
app/retail/emails.py 19.76% <0%> (ø) ⬆️
...board/management/commands/cleanup_dupe_profiles.py 0% <0%> (ø)
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57e02a...7b2e1ae. Read the comment docs.

@Dgilliams
Copy link
Contributor Author

Dgilliams commented Oct 12, 2018

@mbeacom you got it! :)

@stickler-ci
Copy link

Could not review pull request. It may be too large, or contain no reviewable changes.

@mbeacom
Copy link
Contributor

mbeacom commented Oct 12, 2018

@Dgilliams I updated the original URL after I posted it. https://github.com/gitcoinco/creative should be public and available. I think @PixelantDesign has some recommendations as well, so you could probably wait for her followup before PRing there, though.

@stickler-ci
Copy link

Could not review pull request. It may be too large, or contain no reviewable changes.

@Dgilliams
Copy link
Contributor Author

color_palette

@stickler-ci
Copy link

Could not review pull request. It may be too large, or contain no reviewable changes.

@Dgilliams
Copy link
Contributor Author

red hair should be an option imo :) #gingerpride

@stickler-ci
Copy link

Could not review pull request. It may be too large, or contain no reviewable changes.

@@ -82,14 +82,21 @@ def get_avatar_context():
'title': 'Pick a hairstyle',
'options': (['None', '0'], ['None', '1'], ['None', '2'], ['None', '3'], ['None', '4'],
['5', 'None'], ['6-back', '6-front'], ['7-back', '7-front'], ['8-back', '8-front'],
['9-back', '9-front'], ['None', '10'])
['9-back', '9-front'], ['None', '10'],
['damos_hair-back'. 'damos_hair-front'],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E999 SyntaxError: invalid syntax

@Dgilliams
Copy link
Contributor Author

@mbeacom is the new directory ok?
I also added several new hair assets.
This is my first experience with Docker and I haven't quite got it running yet. Any chance you could help me out? I want to make sure these work before knocking out more assets.

@willsputra
Copy link
Contributor

@Dgilliams This looks great! Would definitely be helpful for designers like me to work on avatar bounties without starting from scratch.

Also love how you put the default color schemes, grid, strokes from the styleguide. The attention to detail is much appreciated. 😊

Few comments from me:

  1. Could we make the no-hair, no-accessories base as the default? Would make it easier for me if I want to create new hairstyles/accessories/clothes
  2. Also notice the left ear looks kinda odd

screenshot 2018-10-18 23 50 53

3. I might be nitpicking here but I think the jaw should be sliiiightly wider (follow the blue line) and the taper starts sliiiightly lower (below the dashed line)

screenshot 2018-10-18 23 53 55

Let me know if you need any help? Can't wait to push this through the finish line 🤩
Thanks a lot!

cc @PixelantDesign

@Dgilliams
Copy link
Contributor Author

@willsputra You're very welcome. I hope it gives you and others the courage to jump in and start creating. I appreciate the nitpicky-ness :) I'll fix those real quick. Keep the notes coming! There are other things I'd like to make better as I make other assets for the generator, but I wanted to get it out there quickly for others to use. This file can still be much better.

The art on top was left as default as an example so others can see how the shapes and outlines should be before exporting. It's pretty quick to delete what's there and save your own template file. This did just make me wonder... should there be two files? one as a blank template and the other is an example?

Remember to select "size to artboard" when exporting any svg assets :D

@Dgilliams
Copy link
Contributor Author

@willsputra file is updated. I left the art in there, lol I actually added more for a little variety. I realized as I was deleting it all down to the base that it's nice to have something to start with. ex: If I only want to design eyes, I don't want to need to import hair to see how it looks among other assets.

@willsputra
Copy link
Contributor

@Dgilliams wow that was fast! :) this looks good to me. @PixelantDesign any comments?

@Dgilliams
Copy link
Contributor Author

@ALL, finally got my docker instance working right. I swear I did the same steps the other day and it wouldn't launch. Don't pull this in yet. I found a few things that need adjustments.

… for the inverted mohawk but I kinda like it with the red streak. Lmk if we should keep it. Still having an issue with facial hair not showing up tho...
@Dgilliams
Copy link
Contributor Author

Dgilliams commented Oct 20, 2018

avatar_ex_1
avatar_ex_2

This was unintentional but I thought it was kinda cool with the red streak. Thoughts?
avatar_ex_3_inverted_mohawk
avatar_ex_4_mohawk
avatar_ex_5

Is there something special I should be doing with the beard and mustache files?
no_beard_err

@Dgilliams
Copy link
Contributor Author

@ALL, @PixelantDesign, @willsputra
I removed the beard since it only fit my face shape. Everything else is ready to go. 4ish new hair styles. This should be ready for a merge.

@owocki owocki merged commit 56bc919 into gitcoinco:master Nov 5, 2018
@PixelantDesign
Copy link
Contributor

Thanks @Dgilliams!

@willsputra
Copy link
Contributor

Awesome @Dgilliams!

@Dgilliams
Copy link
Contributor Author

No problem 🤘🤓 @PixelantDesign @willsputra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants