new avatar items #2401

owocki · 2018-10-09T20:37:30Z

further just trying to understand sketch and add a shirt

adds an eth-trek logo to the avatar builder

jack o lantern

robe and parrot

stickler-ci · 2018-10-09T20:37:40Z

app/avatar/utils.py

@@ -72,7 +72,7 @@ def get_avatar_context():
            {
                'name': 'Clothing',
                'title': 'Pick your clothing',
-                'options': ('cardigan', 'hoodie', 'knitsweater', 'plaid', 'shirt', 'shirtsweater', 'spacecadet')
+                'options': ('cardigan', 'hoodie', 'knitsweater', 'plaid', 'shirt', 'shirtsweater', 'spacecadet', 'ethlogo')


E501 line too long (123 > 120 characters)

codecov · 2018-10-09T20:43:18Z

Codecov Report

Merging #2401 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2401   +/-   ##
=======================================
  Coverage   29.27%   29.27%           
=======================================
  Files         147      147           
  Lines       11872    11872           
  Branches     1605     1605           
=======================================
  Hits         3475     3475           
  Misses       8279     8279           
  Partials      118      118

Impacted Files	Coverage Δ
app/avatar/utils.py	`18.43% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f14667...2217e6c. Read the comment docs.

owocki · 2018-10-09T20:44:31Z

when u want to market to nerds, you do something star trek inspired:

stickler-ci · 2018-10-10T00:48:51Z

app/avatar/utils.py

@@ -93,7 +93,7 @@ def get_avatar_context():
                'options': (['Glasses-0'], ['Glasses-1'], ['Glasses-2'], ['Glasses-3'], ['Glasses-4'],
                            ['HatShort-backwardscap'], ['HatShort-ballcap'], ['HatShort-headphones'],
                            ['HatShort-shortbeanie'], ['HatShort-tallbeanie'], ['Earring-0'], ['Earring-1'],
-                            ['EarringBack-2', 'Earring-2'], ['Earring-3'], ['Earring-4'], ['Masks-jack-o-lantern'])
+                            ['EarringBack-2', 'Earring-2'], ['Earring-3'], ['Earring-4'], ['Masks-jack-o-lantern'], ['Extras-Parrot'])


E501 line too long (134 > 120 characters)

stickler-ci · 2018-10-10T00:56:56Z

app/avatar/utils.py

@@ -72,7 +72,7 @@ def get_avatar_context():
            {
                'name': 'Clothing',
                'title': 'Pick your clothing',
-                'options': ('cardigan', 'hoodie', 'knitsweater', 'plaid', 'shirt', 'shirtsweater', 'spacecadet')
+                'options': ('cardigan', 'hoodie', 'knitsweater', 'plaid', 'shirt', 'shirtsweater', 'spacecadet', 'ethlogo', 'cloak')


E501 line too long (132 > 120 characters)

stickler-ci · 2018-10-10T01:02:46Z

app/avatar/utils.py

@@ -72,7 +72,7 @@ def get_avatar_context():
            {
                'name': 'Clothing',
                'title': 'Pick your clothing',
-                'options': ('cardigan', 'hoodie', 'knitsweater', 'plaid', 'shirt', 'shirtsweater', 'spacecadet')
+                'options': ('cardigan', 'hoodie', 'knitsweater', 'plaid', 'shirt', 'shirtsweater', 'spacecadet', 'ethlogo', 'cloak', 'robe')


E501 line too long (140 > 120 characters)

stickler-ci · 2018-10-10T01:03:56Z

app/avatar/utils.py

@@ -93,7 +93,7 @@ def get_avatar_context():
                'options': (['Glasses-0'], ['Glasses-1'], ['Glasses-2'], ['Glasses-3'], ['Glasses-4'],
                            ['HatShort-backwardscap'], ['HatShort-ballcap'], ['HatShort-headphones'],
                            ['HatShort-shortbeanie'], ['HatShort-tallbeanie'], ['Earring-0'], ['Earring-1'],
-                            ['EarringBack-2', 'Earring-2'], ['Earring-3'], ['Earring-4'], ['Masks-jack-o-lantern'])
+                            ['EarringBack-2', 'Earring-2'], ['Earring-3'], ['Earring-4'], ['Masks-jack-o-lantern'], ['Masks-jack-o-lantern-lighted'], ['Extras-Parrot'])


E501 line too long (168 > 120 characters)

mbeacom

Do we want to include the dynamic .txt templates for these as well?

thelostone-mc · 2018-10-11T10:37:31Z

compressed and fixed linting ^_^
@owocki we would need the .txt too

owocki · 2018-10-11T15:50:01Z

hey @thelostone-mc @mbeacom i see this example of the dynamic .txts -- whats the different between futuristic_pony_back.txt and futuristic_pony_front.txt? where is futuristic_pony_back and futuristic_pony_front linked in the app? i.e. how does the backend know that futuristic_pony_* is the same as app/assets/v2/images/avatar/HairStyle/9-front-F0E6FF.svg ?

…eth-logo

owocki · 2018-10-13T23:37:06Z

@mbeacom @thelostone-mc i figured it out... fix is in => 14d6707

stickler-ci · 2018-10-14T20:18:25Z

app/avatar/utils.py

@@ -73,14 +73,15 @@ def get_avatar_context():
            {
                'name': 'Clothing',
                'title': 'Pick your clothing',
-                'options': ('cardigan', 'hoodie', 'knitsweater', 'plaid', 'shirt', 'shirtsweater', 'spacecadet', 'suit')
+                'options': ('cardigan', 'hoodie', 'knitsweater', 'plaid', 'shirt', 'shirtsweater', 'spacecadet', 'suit', 'ethlogo', 'cloak', 'robe')


E501 line too long (148 > 120 characters)

stickler-ci · 2018-10-14T20:18:25Z

app/avatar/utils.py

-                            ['None', '10'])
+                'options': (
+                    ['None', '0'], ['None', '1'], ['None', '2'], ['None', '3'], ['None', '4'], ['5', 'None'],
+                    ['6-back', '6-front'], ['7-back', '7-front'], ['8-back', '8-front'], ['9-back', '9-front'], ['None', '10']


E501 line too long (126 > 120 characters)

owocki · 2018-10-14T20:18:34Z

9c3c799
fixes merge conflcits

owocki · 2018-10-14T20:21:27Z

e586c3b make fix in da house

owocki · 2018-10-14T20:22:32Z

tested.. seems fine

dhimanparamjeet · 2019-02-27T16:39:05Z

I add new items in clothing. Please check my work @owocki PR #3855

owocki added 2 commits October 9, 2018 14:23

lighted jack o lanter on avatar builder

77bbd42

adds an eth-trek logo to the avatar builder

d521a0f

stickler-ci reviewed Oct 9, 2018

View reviewed changes

owocki mentioned this pull request Oct 9, 2018

added pony for avatar builder #2373

Merged

owocki mentioned this pull request Oct 9, 2018

New Avatar Assets -- October 2018 Edition #2333

Closed

5 tasks

parrot

c45d086

stickler-ci reviewed Oct 10, 2018

View reviewed changes

owocki added 2 commits October 9, 2018 18:49

adds a parrot

c930115

adds cloak

dc1772d

stickler-ci reviewed Oct 10, 2018

View reviewed changes

robe

b5982d3

stickler-ci reviewed Oct 10, 2018

View reviewed changes

jack o lantern

1337a22

owocki changed the title ~~adds an eth-trek logo to the avatar builder~~ new avatar items Oct 10, 2018

stickler-ci reviewed Oct 10, 2018

View reviewed changes

mbeacom reviewed Oct 11, 2018

View reviewed changes

svg: compress + eslint: fix

0b984a3

owocki added 3 commits October 11, 2018 14:32

adds gitcoin bot

f74e6ab

Merge branch 'kevin/eth-logo' of github.com:gitcoinco/web into kevin/…

8a36d9f

…eth-logo

code review for avatar extras

14d6707

owocki added 2 commits October 13, 2018 17:39

herpity derpity

a7bc1b9

merge conflictx

9c3c799

stickler-ci reviewed Oct 14, 2018

View reviewed changes

lint-ey lint-ey

e586c3b

parrot fix?

2217e6c

owocki merged commit 8bbe12e into master Oct 14, 2018

thelostone-mc deleted the kevin/eth-logo branch October 15, 2018 03:43

owocki mentioned this pull request Nov 4, 2018

New Avatar Assets -- November 2018 Edition #2684

Closed

5 tasks

owocki mentioned this pull request Dec 13, 2018

New Avatar Assets -- Winter 2019 #3195

Closed

5 tasks

owocki mentioned this pull request Feb 9, 2019

New Avatar Assets -- Spring 2019 #3713

Closed

5 tasks

This was referenced Mar 31, 2023

[Snyk] Upgrade @pulumi/aws from 5.11.0 to 5.30.1 misbahqadri/web#187

Open

[Snyk] Upgrade @pulumi/aws from 5.11.0 to 5.31.0 misbahqadri/web#194

Open

snyk-bot mentioned this pull request Apr 11, 2023

[Snyk] Upgrade @pulumi/aws from 5.11.0 to 5.32.0 misbahqadri/web#199

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new avatar items #2401

new avatar items #2401

owocki commented Oct 9, 2018 •

edited

Loading

stickler-ci Oct 9, 2018

codecov bot commented Oct 9, 2018 •

edited

Loading

owocki commented Oct 9, 2018

stickler-ci Oct 10, 2018

stickler-ci Oct 10, 2018

stickler-ci Oct 10, 2018

stickler-ci Oct 10, 2018

mbeacom left a comment

thelostone-mc commented Oct 11, 2018

owocki commented Oct 11, 2018

owocki commented Oct 13, 2018

stickler-ci Oct 14, 2018

stickler-ci Oct 14, 2018

owocki commented Oct 14, 2018

owocki commented Oct 14, 2018

owocki commented Oct 14, 2018

dhimanparamjeet commented Feb 27, 2019 •

edited

Loading

new avatar items #2401

new avatar items #2401

Conversation

owocki commented Oct 9, 2018 • edited Loading

stickler-ci Oct 9, 2018

Choose a reason for hiding this comment

codecov bot commented Oct 9, 2018 • edited Loading

Codecov Report

owocki commented Oct 9, 2018

stickler-ci Oct 10, 2018

Choose a reason for hiding this comment

stickler-ci Oct 10, 2018

Choose a reason for hiding this comment

stickler-ci Oct 10, 2018

Choose a reason for hiding this comment

stickler-ci Oct 10, 2018

Choose a reason for hiding this comment

mbeacom left a comment

Choose a reason for hiding this comment

thelostone-mc commented Oct 11, 2018

owocki commented Oct 11, 2018

owocki commented Oct 13, 2018

stickler-ci Oct 14, 2018

Choose a reason for hiding this comment

stickler-ci Oct 14, 2018

Choose a reason for hiding this comment

owocki commented Oct 14, 2018

owocki commented Oct 14, 2018

owocki commented Oct 14, 2018

dhimanparamjeet commented Feb 27, 2019 • edited Loading

owocki commented Oct 9, 2018 •

edited

Loading

codecov bot commented Oct 9, 2018 •

edited

Loading

dhimanparamjeet commented Feb 27, 2019 •

edited

Loading