[WIP] Added title and meta tags #2225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aashutoshrathi could we get this in by tom ? |
mbeacom
reviewed
Sep 17, 2018
| @@ -22,6 +22,11 @@ | |||
| <head> | |||
| {% include 'shared/head.html' %} | |||
| {% include 'shared/cards.html' %} | |||
| {% block title %} | |||
| Grow Open Source: Find Freelance Developers & Open Bug Bounties - Gitcoin | |||
| {% endblock title%} | |||
There was a problem hiding this comment.
Please adjust the spacing here {% endblock title %}
| @@ -22,6 +22,11 @@ | |||
| <head> | |||
| {% include 'shared/head.html' %} | |||
| {% include 'shared/cards.html' %} | |||
| {% block title %} | |||
| Grow Open Source: Find Freelance Developers & Open Bug Bounties - Gitcoin | |||
There was a problem hiding this comment.
@thelostone-mc Think we should i18n this?
package-lock.json
Outdated
| "supports-color": "5.4.0" | ||
| "ansi-styles": "^3.2.1", | ||
| "escape-string-regexp": "^1.0.5", | ||
| "supports-color": "^5.3.0" |
There was a problem hiding this comment.
Any reason for these lock changes? Can we omit this file?
|
@thelostone-mc will finish this today |
mbeacom
reviewed
Sep 17, 2018
|
Moved to #2231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All the pages and links mentioned in the above mentioned spreadsheet should have proper titles and meta descriptions based on the given data. The blocks mentioned in red are dynamically generated pages. So for a page like https://gitcoin.co/funding/details?url=a the title should be + "Bug Bounty | Gitcoin">
Checklist
Affected core subsystem(s)
SEO mainly HTML files.
Refers/Fixes
Fixes #2147