Fixes admin priviledge to stop work in activity #2167
Conversation
|
Let's get this tested once on staging. |
Codecov Report
@@ Coverage Diff @@
## master #2167 +/- ##
=======================================
Coverage 27.75% 27.75%
=======================================
Files 141 141
Lines 11367 11367
Branches 1543 1543
=======================================
Hits 3155 3155
Misses 8102 8102
Partials 110 110Continue to review full report at Codecov.
|
|
Happy to review when this is on staging, just lmk! |
|
@SaptakS wanna rebase and get it on staging ? |
|
@thelostone-mc your wish is my command. But next time add |
|
@SaptakS @thelostone-mc This is on staging. |
| <div class="stop-work"> | ||
| <span title="<div class='tooltip-info tooltip-sm'>Remove this user's started work on the bounty and ding rep</div>"> | ||
| <a id="remove-slash-[[:name]]" class="button button--primary admin-only" role="button" href="remove-handle"> | ||
| <span class="font-smaller-4">Stop work + Ding Rep</span> |
There was a problem hiding this comment.
One thing here... should we modify the newly introduced copy to support i18n?
SaptakS
force-pushed
the
fix/admin-actions
branch
from
d8610b1 to
c40acca
Compare
app/avatar/utils.py
Outdated
| ) | ||
| }], | ||
| }, | ||
| { |
There was a problem hiding this comment.
Can you revert the indent change here?
| null=True, | ||
| blank=True, | ||
| help_text=_('The Github avatar SVG.') | ||
| upload_to=get_upload_filename, null=True, blank=True, help_text=_('The Github avatar SVG.') |
| @@ -44,8 +44,8 @@ class AvatarAdmin(GeneralAdmin): | |||
|
|
|||
| ordering = ['-id'] | |||
| fields = [ | |||
| 'config', 'use_github_avatar', 'svg_asset', 'custom_png_asset', 'github_svg_asset', | |||
| 'png_asset', 'created_on', 'modified_on' | |||
| 'config', 'use_github_avatar', 'svg_asset', 'custom_png_asset', 'github_svg_asset', 'png_asset', 'created_on', | |||
app/dataviz/views.py
Outdated
| }, ] | ||
| }, | ||
| { | ||
| 'title': 'web => bounties_posted => bounties_fulfilled (detail)', |
There was a problem hiding this comment.
Can you revert the indent change here?
Description
ensure that when a worker has applied -> funder/admin can ONLY approve / reject.
Upon being approved -> funder/admin would be able to stop work / stop work + ding repo
Checklist
Affected core subsystem(s)
Testing
Refers/Fixes
Fixes #2165