Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transaction link in waiting state page obvious #2134

Merged
merged 2 commits into from
Jun 22, 2019

Conversation

arku
Copy link
Contributor

@arku arku commented Aug 31, 2018

Description

The transaction link in the waiting state isn't obvious as there's no visual cue that it's a link. This PR improves the UX by adding an underline style to the link.

Before

image

After

image

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines

/cc @PixelantDesign

@codecov
Copy link

codecov bot commented Aug 31, 2018

Codecov Report

Merging #2134 into master will decrease coverage by 2.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2134      +/-   ##
==========================================
- Coverage    30.3%   27.87%   -2.43%     
==========================================
  Files         214      136      -78     
  Lines       17142    11148    -5994     
  Branches     2319     1502     -817     
==========================================
- Hits         5195     3108    -2087     
+ Misses      11740     7930    -3810     
+ Partials      207      110      -97
Impacted Files Coverage Δ
app/app/context.py 0% <0%> (-56.1%) ⬇️
...arketing/management/commands/new_bounties_email.py 0% <0%> (-53.34%) ⬇️
app/app/thumbnail_processors.py 0% <0%> (-33.34%) ⬇️
...eting/management/commands/assemble_leaderboards.py 50% <0%> (-25.1%) ⬇️
app/dashboard/embed.py 8.04% <0%> (-23.57%) ⬇️
app/dashboard/utils.py 23.34% <0%> (-11.15%) ⬇️
app/marketing/utils.py 29.72% <0%> (-7.08%) ⬇️
app/dashboard/models.py 50.23% <0%> (-6.03%) ⬇️
app/app/urls.py 84.09% <0%> (-5.28%) ⬇️
app/dashboard/router.py 28.26% <0%> (-4.45%) ⬇️
... and 165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18baf8c...0bb47c5. Read the comment docs.

@thelostone-mc
Copy link
Member

@arun1595 could we throw in some padding to give it some breathing space ?

Should be good for merge post that

@PixelantDesign
Copy link
Contributor

Hey @arun1595 why does that first line need an underline?

@arku
Copy link
Contributor Author

arku commented Aug 31, 2018

@PixelantDesign To provide a visual cue to the user that it's a link and not just plain text.

@PixelantDesign
Copy link
Contributor

I think we are mixing informational text with an action. If we should show a link to the etherscan in progress, let's break it out and put it above the GitHub url.

cc: @arun1595 @thelostone-mc

@thelostone-mc thelostone-mc merged commit 3b8af58 into gitcoinco:master Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants