Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: shrunk vertical navbar + refactoring #212

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

thelostone-mc
Copy link
Member

Description
  • shrunk vertical nav from col-3 to col-2
  • refactored base.css
Checklist
Affected core subsystem(s)
  • ui
Refers/Fixes

Refs: #133

@thelostone-mc
Copy link
Member Author

@owocki not big a change, just shrunk down the vertical navbar + refactored css
if it's better as it currently is, close the PR ^_^

@thelostone-mc
Copy link
Member Author

thelostone-mc commented Jan 8, 2018

@owocki yay or nay ? Don't wanna refactor that huge file again to resolve conflicts if we aren't merging it 😛

@owocki
Copy link
Contributor

owocki commented Jan 8, 2018

sry been on vacay. looking now

@owocki
Copy link
Contributor

owocki commented Jan 8, 2018

@thelostone-mc just tested it out.. and it looks quite good.

hard to code review with all of the linting changes... we should all standardize on one linter preferences :)

go ahead nad resolve merge conflicts and i will merge.. pls ping me on slack when ready so that i can merge quickly and not leave the changes outstanding for too logn

- shrunk vertical nav from col-3 to col-2
- refactored base.css
@thelostone-mc
Copy link
Member Author

thelostone-mc commented Jan 8, 2018

@owocki Yeah I know 😓 I followed what's set here
Need to start changing all the files one by one and happiness will be the moment when the linter says -> 100% pass :')

Resolved and ready for merge

@owocki
Copy link
Contributor

owocki commented Jan 8, 2018

happiness will be the moment when the linter says -> 100% pass :')

amen to that

@owocki owocki merged commit e23d0bc into gitcoinco:master Jan 8, 2018
ethikz pushed a commit to ethikz/web that referenced this pull request Jan 24, 2018
css: shrunk vertical navbar +  refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants