Multi-Party Payout Recipients Not Showing in 'Work Done' # #2040
Conversation
| github_username : github_username.concat(','); | ||
|
|
||
| accepted.push(profileHtml(github_username, name)); | ||
| }); | ||
| } | ||
| } | ||
| if (result.fulfillments) { |
app/dashboard/models.py
Outdated
| def paid(self): | ||
| """Return list of users paid for this bounty.""" | ||
| if self.status != 'done': | ||
| return [] #to save the db hits |
There was a problem hiding this comment.
E261 at least two spaces before inline comment
E262 inline comment should start with '# '
app/dashboard/models.py
Outdated
| """Return list of users paid for this bounty.""" | ||
| if self.status != 'done': | ||
| return [] #to save the db hits | ||
|
|
There was a problem hiding this comment.
W293 blank line contains whitespace
app/dashboard/models.py
Outdated
|
|
||
| return_list = [] | ||
| for fulfillment in self.fulfillments.filter(accepted=True): | ||
| if fulfiller.fulfiller_github_username: |
app/dashboard/models.py
Outdated
| return_list = [] | ||
| for fulfillment in self.fulfillments.filter(accepted=True): | ||
| if fulfiller.fulfiller_github_username: | ||
| return_list.append(fulfiller_github_username) |
There was a problem hiding this comment.
F821 undefined name 'fulfiller_github_username'
Codecov Report
@@ Coverage Diff @@
## master #2040 +/- ##
==========================================
- Coverage 27.75% 27.74% -0.01%
==========================================
Files 132 132
Lines 10914 10927 +13
Branches 1460 1465 +5
==========================================
+ Hits 3029 3032 +3
- Misses 7778 7788 +10
Partials 107 107
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I modified the dashboard/[email protected] method to resolve the undefined variable errors (fulfiller vs fulfillment & fulfiller_github_username vs fulfillment.fulfiller_github_username) and the stickler warning for comment spacing.
I haven't tested this yet, but code lgtm.
Description
Multi-Party Payout Recipients Not Showing in 'Work Done' #
This fixes this, but doing two main things
Checklist
Affected core subsystem(s)
bounty details
Testing
tested it
screenshot: http://bits.owocki.com/2L3W0R2Y423M/Screen%20Shot%202018-08-20%20at%205.01.30%20PM.png
Refers/Fixes
#1983