Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecates old tip receive flow #2027

Merged
merged 2 commits into from
Aug 21, 2018
Merged

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Aug 17, 2018

deprecates old tip receive flow, v1 and v2, which aren't used anymore.

@codecov
Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #2027 into master will increase coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2027      +/-   ##
==========================================
+ Coverage   25.33%   25.47%   +0.13%     
==========================================
  Files         132      132              
  Lines       10904    10827      -77     
  Branches     1459     1451       -8     
==========================================
- Hits         2763     2758       -5     
+ Misses       8064     7992      -72     
  Partials       77       77
Impacted Files Coverage Δ
app/dashboard/tip_views.py 21.17% <ø> (+2.57%) ⬆️
app/app/urls.py 85.71% <ø> (ø) ⬆️
app/dashboard/models.py 48.22% <0%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73b3818...d8b7de6. Read the comment docs.

@mbeacom
Copy link
Contributor

mbeacom commented Aug 21, 2018

Testing on staging - I'll merge if everything is 💚

@mbeacom
Copy link
Contributor

mbeacom commented Aug 21, 2018

Everything seems fine on stage. Merging!

@mbeacom mbeacom merged commit c2a304b into master Aug 21, 2018
@mbeacom mbeacom deleted the kevin/deprecate_old_receive_flows branch August 21, 2018 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants