Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: fixes #1998

Merged
merged 2 commits into from
Aug 20, 2018
Merged

css: fixes #1998

merged 2 commits into from
Aug 20, 2018

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Aug 14, 2018

Description
  • css refactor + update payout html + css
  • lint fixes
  • removed un-needed animation
Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • css
Refers/Fixes

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #1998 into master will increase coverage by 2.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1998      +/-   ##
==========================================
+ Coverage   25.33%   27.76%   +2.43%     
==========================================
  Files         132      132              
  Lines       10904    10904              
  Branches     1459     1459              
==========================================
+ Hits         2763     3028     +265     
+ Misses       8064     7769     -295     
- Partials       77      107      +30
Impacted Files Coverage Δ
app/git/utils.py 47.31% <0%> (+0.31%) ⬆️
app/dashboard/notifications.py 16.92% <0%> (+0.59%) ⬆️
app/dashboard/utils.py 23.62% <0%> (+1.57%) ⬆️
app/dashboard/models.py 49.42% <0%> (+2.3%) ⬆️
app/dashboard/signals.py 60% <0%> (+12%) ⬆️
...marketing/management/commands/remarket_bounties.py 50% <0%> (+50%) ⬆️
...eting/management/commands/assemble_leaderboards.py 52.2% <0%> (+52.2%) ⬆️
...eting/management/commands/expiration_start_work.py 75% <0%> (+75%) ⬆️
app/marketing/management/commands/roundup.py 82.35% <0%> (+82.35%) ⬆️
app/marketing/management/commands/expiration.py 90.47% <0%> (+90.47%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73b3818...2fd87a9. Read the comment docs.

@thelostone-mc thelostone-mc force-pushed the derp branch 3 times, most recently from 50edd82 to ae0a7af Compare August 16, 2018 08:46
@thelostone-mc thelostone-mc self-assigned this Aug 20, 2018
@thelostone-mc thelostone-mc added frontend This needs frontend expertise. needs review and removed in progress labels Aug 20, 2018
Copy link
Contributor

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SaptakS SaptakS merged commit f0f7ae1 into gitcoinco:master Aug 20, 2018
@thelostone-mc thelostone-mc deleted the derp branch August 20, 2018 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants