Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust gitcoin bot get_notifications to use pygithub #1977

Merged
merged 2 commits into from
Sep 27, 2018

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Aug 9, 2018

Description

The goal of this PR is to resolve #1976 and make use of pygithub versus using requests for gathering github notifications.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

notifications

Testing

Locally

Refers/Fixes

Fixes #1976

@mbeacom mbeacom added backend This needs backend expertise. notifications labels Aug 9, 2018
@mbeacom mbeacom self-assigned this Aug 9, 2018
@codecov
Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #1977 into master will decrease coverage by <.01%.
The diff coverage is 10%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1977      +/-   ##
=========================================
- Coverage    27.8%   27.8%   -0.01%     
=========================================
  Files         137     137              
  Lines       11178   11182       +4     
  Branches     1510    1510              
=========================================
+ Hits         3108    3109       +1     
- Misses       7960    7963       +3     
  Partials      110     110
Impacted Files Coverage Δ
...itcoinbot/management/commands/get_notifications.py 0% <0%> (ø) ⬆️
app/git/utils.py 46.89% <20%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b53e584...d4864a8. Read the comment docs.

@SaptakS SaptakS merged commit 535801f into master Sep 27, 2018
@thelostone-mc thelostone-mc deleted the fix-1976-gcbot-notifs branch December 28, 2018 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This needs backend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_notifications - TypeError: string indices must be integers
3 participants