-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all-caps default in /tip (yge) #195
Conversation
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=======================================
Coverage 12.21% 12.21%
=======================================
Files 66 66
Lines 3120 3120
Branches 343 343
=======================================
Hits 381 381
Misses 2739 2739 Continue to review full report at Codecov.
|
we somehow should unify the different stylesheets that are used. |
By loading the gicoin.css stylesheet the headlines in yge will be uppercase as in the rest of the application. This is a first step to try to move towards a unified stylesheet for the two different components of the app.
awesome, thank you :) |
⚡️ A tip worth 0.02 ETH ($17.27) has been granted to @bumi for this issue from Kevin. ⚡️ The sender had the following public comments:
Nice work @bumi, check your email for further instructions.
|
@@ -21,7 +21,7 @@ | |||
</span> | |||
<h1>Send Tip ⚡</h1> | |||
<h3>It's Fast. It's Easy. It's Free.️</h3> | |||
<h4>(Supports any github username or email address)</h4> | |||
<p>(Supports any github username or email address)</p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh nooo... I commited broken HTML.
As this PR is already merged, this is fixed in: a6a4c7d#diff-88a1050efecc8245bddec63cb35b9412R24
BUT as that other PR is kinda big, shall I do a quick PR to fix only this error, that we easily can merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npnp ill fix it directly on master
This issue now has a funding of 0.05 ETH (42.76 USD) attached to it.
|
The funding of 0.05 ETH (42.84 USD) attached has been claimed by @owocki. @owocki, please leave a comment to let the funder (@owocki) and the other parties involved your implementation plan. If you don't leave a comment, the funder may expire your claim at their discretion.
|
accidental bounty. claiming it myself now |
The funding of 0.05 ETH (42.84 USD) attached to this issue has been approved & issued to @owocki.
|
any idea how we should approach the bounty status text normalization? |
sorry, im not sure i follow the question. |
I was referring to the second topic in #151 |
Remove all-caps default in /tip (yge)
Description
Similar to #116 and discussed in #151 this PR removes the global (on body)
text-transform: uppercase
style from the /tip (yge) application.As discussed in #151 properties like the bounty status should also be normalized (capitalized in the UI)
These properties are stored in the DB and we need to decide where to put that presentation logic.
Checklist
Affected core subsystem(s)
ui
Refers/Fixes