Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sends an email to funders who have been inactive for 30 days, asking if they have any feedback #1894

Merged
merged 5 commits into from
Aug 1, 2018

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Jul 31, 2018

Description

sends an email to funders who have been inactive for 30 days, asking if they have any feedback

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

email

Testing

tested it

Refers/Fixes

#1872
#1879

return

# config
days = 30 # TODO: do we want to send another variant of this email at 90 days, 180 days?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E261 at least two spaces before inline comment


if not handle:
continue

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W293 blank line contains whitespace

).exists()

if not has_posted_in_last_days_days:
# TODO: do we want to suppress the email if the user

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W291 trailing whitespace

print(" - has posted recently; not sending")



Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W391 blank line at end of file


i see you haven't posted any funded work to the platform in {time_as_str}.

just wanted to check in and see if there's anything we can do, or if you had any feedback for us. we're still a small startup and we iterate fast; not only will your feedback be heard, but it's got a good chance of being put into the product roadmap!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E501 line too long (251 > 120 characters)


kevin

PS - i've got some new gitcoin schwag on order. send me your mailing address and your t shirt size and i'll ship you some.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E501 line too long (122 > 120 characters)

@@ -675,6 +700,13 @@ def bounty_feedback(request):
return HttpResponse(response_html)


@staff_member_required
def funder_stale(request):
from dashboard.models import Bounty

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F401 'dashboard.models.Bounty' imported but unused

@owocki
Copy link
Contributor Author

owocki commented Jul 31, 2018

TODO: send this email at higher variants after this PR is merged. crontab will do the rest

@codecov
Copy link

codecov bot commented Jul 31, 2018

Codecov Report

Merging #1894 into master will decrease coverage by 0.11%.
The diff coverage is 6.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1894      +/-   ##
==========================================
- Coverage   25.59%   25.47%   -0.12%     
==========================================
  Files         129      130       +1     
  Lines       10474    10534      +60     
  Branches     1395     1404       +9     
==========================================
+ Hits         2681     2684       +3     
- Misses       7716     7773      +57     
  Partials       77       77
Impacted Files Coverage Δ
app/app/urls.py 90% <ø> (ø) ⬆️
...arketing/management/commands/funder_stale_email.py 0% <0%> (ø)
app/marketing/mails.py 11.79% <16.66%> (-0.08%) ⬇️
app/retail/emails.py 20.24% <18.18%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26872bb...80b127a. Read the comment docs.

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - Adjusted some url() calls to path or re_path as necessary (url() is being deprecated), wrapped lines to not exceed 120 characters, and added docstrings to new methods.

@PixelantDesign
Copy link
Contributor

PixelantDesign commented Aug 1, 2018

This is cool - lots of opps to use behavioral techniques here. Could you fire an example email?

cc @owocki

@owocki
Copy link
Contributor Author

owocki commented Aug 1, 2018

@PixelantDesign if you have any ideas for other emails we should, like this, put elsewhere in the funnel... let me know

will fire a test email today

@owocki owocki merged commit d4bace3 into master Aug 1, 2018
@mbeacom mbeacom deleted the kevin/funder_stale branch August 2, 2018 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants