Split create_new_bounty kwargs building and check if once #1892

mbeacom · 2018-07-31T22:23:08Z

Description

The goal of this PR is to reduce the number of checks whether or not latest_old_bounty exists and offload the last_old_bounty to a class level method for pertinent dict keys/values.

Checklist

linter status: 100% pass
changes don't break existing behavior
commit message follows commit guidelines

Affected core subsystem(s)

bounty creation/updating

Testing

Locally via sync_geth

codecov · 2018-07-31T22:27:21Z

Codecov Report

Merging #1892 into master will decrease coverage by <.01%.
The diff coverage is 18.75%.

@@            Coverage Diff             @@
##           master    #1892      +/-   ##
==========================================
- Coverage   25.52%   25.51%   -0.01%     
==========================================
  Files         130      130              
  Lines       10669    10683      +14     
  Branches     1420     1423       +3     
==========================================
+ Hits         2723     2726       +3     
- Misses       7868     7879      +11     
  Partials       78       78

Impacted Files	Coverage Δ
app/dashboard/helpers.py	`17.2% <12.5%> (-0.02%)`	⬇️
app/economy/models.py	`77.77% <25%> (-7.68%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 383ac60...4641760. Read the comment docs.

thelostone-mc · 2018-08-02T12:34:21Z

app/dashboard/helpers.py

-                privacy_preferences=bounty_payload.get('privacy_preferences', {}) if not latest_old_bounty else latest_old_bounty.privacy_preferences,
-                expires_date=timezone.make_aware(
+                    timezone=UTC),
+                'github_url': url,


thelostone-mc

owocki · 2018-08-02T18:34:42Z

app/dashboard/helpers.py

+                'network': bounty_details.get('network'),
+                'bounty_type': metadata.get('bountyType', ''),
+                'project_length': metadata.get('projectLength', ''),
+                'experience_level': metadata.get('experienceLevel', ''),


oooh this is much cleaner... yay!

owocki · 2018-08-02T18:35:10Z

app/dashboard/models.py

@@ -827,6 +827,41 @@ def additional_funding_summary_sentence(self):
            sentence += f" worth ${afs['usd_value']}"
        return sentence

+    def creation_to_dict(self):
+        return {
+            # info to xfr over from self as override fields (this is because sometimes


is there not a django object to dict() method that we could just use?

There's a django.forms utility method to do this... I suppose I can use that.

@owocki Updated to use django.form.models.model_to_dict

owocki

👍 @mbeacom kevin owocki has sent you a 'boy scout' kudos for leaving this code better than you found it!

mbeacom · 2018-08-02T19:38:07Z

@thelostone-mc @owocki Can I have another review of this PR? I have introduced the SuperModel.to_standard_dict method until we update previously implemented to_dict() methods on some of the subclasses to maintain parity. But now, we can simply call to_standard_dict() on any of our subclasses of SuperModel and get a dictionary representation. to_standard_dict also takes the same two kwargs as model_to_dict to allow for customization of the returned dictionary as shown in the one usage example so far.

owocki · 2018-08-02T21:40:05Z

app/dashboard/helpers.py

+            })
+        else:
+            latest_old_bounty_dict = latest_old_bounty.to_standard_dict(
+                fields=[


is fields used here?

oh wait nvm i see it now

owocki

didnt test, can you test a bounty end to end of rinkeby?

code LGTM

mbeacom · 2018-08-02T23:26:40Z

https://stage.gitcoin.co/issue/mbeacom/test-repo/64/979

owocki · 2018-08-06T22:13:54Z

thelostone-mc

LGTM

* 'master' of https://github.com/gitcoinco/web: (76 commits) hack: trailing slash for profile (gitcoinco#1937) Minor tweaks to action plan textarea (gitcoinco#1856) fixes label on gas guzzler page, and adds an admin view for vizuailzations keep an eye on unsubscribes in preferences keep an eye on unsubscribes in preferences Split create_new_bounty kwargs building and check if once (gitcoinco#1892) press satisfy linter fix for https://gitcoincore.slack.com/archives/CAXQ7PT60/p1533912000000126 Update profile check to getattr share link not edit link does tip receive math in BigNumber, bc JS rounding issues copy updates newsletter 8/10 fix for slack not showing UP gas guzzlers linter gas guzzlers Error: insufficient funds for gas * price + value starts to track gas guzzlers, for later inclusion in the gitcoin gas station ...

* put reasons above the other two modules * gitcoinco#1854 * css: minor refactor * token approvals * fix for email not being sent * retail: added template tag matches - matches tag does a regex match - updated nav to use matches to display network status on explorer, issue, bounty - create + submit + payout pages * code refactor + clean up - removed redundant uris - reindent code - fixed uneven padding of network banner on tip page * send2: convert CRLF -> LF * isort fixes * console error, responseJSON did not exist * change name of missing image * fix for exception in bounty.additional_funding_summary_sentence() * funder stale email * linter stinter * days * Fix linting issues and docstyle all teh thingz * Fix bad variable out of scope reference in render_bounty_startwork_expired email * restructure: landing - renamed index -> funder - moved funder related templates into it's own folder - added heading to top contributors * restructure: dashboard - renamed _dashboard -> dashboard - renamed dashboard.html -> dasboard/index.html * onboard: prettified metamask wallet address * Sentry integration (gitcoinco#1846) * Sentry integration - deprecate rollbar * Imports are hard * dbl quotez * Single quotes * Fix travis * Forgot to save this file xD * Add middleware and wsgi handler * Logging adjustments for Sentry * Fix gitcoinco#1898 - Adjust ordering of mailchimp args and cast envvars to str * Merge branch 'master' into restructure * gitcoinco@dead551#diff-8d7b20d795398cf2b0e792ee8c1a165c * space in sentence * Update presskit copy (gitcoinco#1900) * Fix sentry release script revision handling * add no a token page * disabled metamask * stickler hate me * add item to menu * dashboard: remove tech stack filter * fixes press kit * add no a token page * blank * Solve conflicts * sitemap fixes * disabled metamask * stickler hate me * i have grammar OCD * bad link * Fix gitcoin logo * documentation about chain of custody * cahin of custoyddyyyyyyyyyy * Modify raven handling * Add sentry request feedback on error * Extending expiration backend code added * Some minor changes * Adds cancel button * Adds alert notifying extending of expiration * Fixes linting issues * expiration: final touches - stickler fixes - show current expiration in modal - add stopwatch icon - extra css * Fixes travis * shared.js/mutate_interest: Show a generic message on network errors. followup 3960c6 PR gitcoinco#1681 * Round up millisecond position * Moderators v1 (gitcoinco#1903) * Ref gitcoinco#1669 - Base escalation/interest statuses and handling * Moderation changes * Add faucet change to perms * No mod * Fix mig for local * Update mod handling throughout remaining views and check gh closures * Whoops * Fix some tests * Fix some pytest cases * Fix more tests * indent fix * More test changes * Add property back to tips method * Fix gitcoinco#1919 - Catch attribute error if the keywords prop isn't a string * Adjust Raven JS to no longer load async * Revert "Adjust Raven JS to no longer load async" This reverts commit 37d4584. * Fix funding/details path * Adjust github details field * gh dict * catch on gh details * Remove temporarily * Disable url dict * Disable GH funcs * Display project length in issue details page * Fix GH token usage * translation tags and clarification on lcoalhost * facebook verify * facebook verify * Revert "facebook verify" This reverts commit 50b7ebb. * Revert "facebook verify" This reverts commit 51f5e54. * Adjust saving of gh issue details * sync geth stopgap fix * Adjust default limit on bounty router * Revert "Adjust default limit on bounty router" This reverts commit a7d872c. * stopgap fix * fixes * runs make fix on master branhc * sync mail fix to make it less aggressive * Adjust yapf to no longer touch settings.py * Update precommit yapf config * fix for sync_listener * linting sync_geth * copy updates * merge migration * Adjust gh state checks * Update gh state * Updates to gh pulling... * GH Pulling adjustments * meta tags * title * no ico life * conflicts * fix for https://gitcoincore.slack.com/archives/CC24APWGN/p1533245102000397 * prod bug * prod bug * prod bug * prod bug * graphs r fun * fix for not being able to ERC20 approve tokens * fix for leaderboards * eslint * adjusts hourly rate distribution calculation criteria * Switching tree section * landing: css + refactor * lander video switcharooooooooooooO * joe dominance was busttedd * shared: updated what_is_gitcoin * added branding style to terms page * changed style of headers on terms page, moved terms.txt into terms.html, added blocktrans tag * Confirming Auto-translation (gitcoinco#1916) * Update makefile with build/push/login and add OCI compliant labels * terms: moved to internal css + mt-4 -> mt-5 * Adjust sentry to use split projects * Fix config * Adjust fe sentry template * Sentry adjustments * livestream 8/3 * Sentry adjustments * livestream 8/3 (gitcoinco#1930) * Show Just 1 Alert Banner for ERC20 Token Fixes gitcoinco#1566 * allow trailing slah for profile (gitcoinco#1931) * Improve tip slack notification (gitcoinco#1929) * Improve tip slack notification * Remove title var and simply check tip.github_url * Add new lines * Adjust sentry raven JS * Adjust sentry raven JS * Revert profile url change * Revert "Adjust sentry raven JS" This reverts commit 5432bc4. * Revert "Adjust sentry raven JS" This reverts commit 25e9987. * Sentry adjustments * Final sentry js adjustments! * tip receive is eth * nonce value * bounty: restructure pages * Fix gitcoinco#1949 - Adjust getattr for profile * prod debugging; dupe emails * prod debugging of dupe emails * prod debugging of dupe emails * remove dupe to_email * dupe email fix * dupe email fix * dupe email fix * reverts debug code * fix for bad preferred profile addresses * fix for https://sentry.gitcoin.co/gitcoin/gitcoin-prod-frontend/issues/278/ * http 404 on hidden prfiles * SEO fixes, linting * content type for robots.txt * SEO stuff * sync_geth latest disabler * Fix isort / travis * what_is_gitcoin : revert to old design (gitcoinco#1957) * fix gitcoinco#1921 * Fix gitcoinco#1934 - Resolve funded total in profile (gitcoinco#1935) * fix for https://sentry.gitcoin.co/gitcoin/gitcoin-prod-backend/issues/321/?referrer=slack * support for https://sentry.gitcoin.co/gitcoin/gitcoin-prod-backend/issues/320/?referrer=slack * disqus url now canonical * funder stale args * very small copy change * smarter funder stale emails * fix for ipfs hashes not existing * fix for being redirected to old bounty id upon submission * copy updates * handler for not sending funder stale emails if n email * puts the right network linkn on the web3 waiter * metamask reloader * explorer: ensure results from latest api call are served to the user (gitcoinco#1941) * explorer: abort pending request for fetchingBounties * added review feedback * Upgrade django to 2.1, modify field defaults, and address deprecations (gitcoinco#1915) * Upgrade django to 2.1 and address deprecations * Remove commented out imports * fix: sticker issue * Update reqs * Remove unused import * Fix gitcoinco#1972 - Strip characters from stdbounties_id and check isdigit * replaced misspelled 'deonomination' with 'denomination' throughout the codebase (gitcoinco#1974) * dashboard: uri cleanup (gitcoinco#1971) * img: removed unused images * Resolve outdated deps in package-lock.json * Upgrade FE npm deps * Upgrade FE npm deps * Pin raven * starts to track gas guzzlers, for later inclusion in the gitcoin gas station * Error: insufficient funds for gas * price + value * gas guzzlers * linter * gas guzzlers * fix for slack not showing UP * newsletter 8/10 * copy updates * does tip receive math in BigNumber, bc JS rounding issues * share link not edit link * Update profile check to getattr * fix for https://gitcoincore.slack.com/archives/CAXQ7PT60/p1533912000000126 * satisfy linter * press * Split create_new_bounty kwargs building and check if once (gitcoinco#1892) * Split create_new_bounty kwargs building and check if once * Update to_dict to use model_to_dict form helper * Fix import - whoops * Adjust to dict handling via supermodel method * keep an eye on unsubscribes in preferences * keep an eye on unsubscribes in preferences * fixes label on gas guzzler page, and adds an admin view for vizuailzations * Minor tweaks to action plan textarea (gitcoinco#1856) * Clear example action plan when the textarea is focused * Fix minor typo * hack: trailing slash for profile (gitcoinco#1937) * start work : update placeholder * added feedback

Split create_new_bounty kwargs building and check if once

06c0fbb

mbeacom added backend This needs backend expertise. bounties labels Jul 31, 2018

mbeacom self-assigned this Jul 31, 2018

mbeacom requested a review from owocki July 31, 2018 22:23

mbeacom added the in progress label Jul 31, 2018

mbeacom requested review from thelostone-mc and SaptakS August 1, 2018 15:42

thelostone-mc reviewed Aug 2, 2018

View reviewed changes

thelostone-mc previously approved these changes Aug 2, 2018

View reviewed changes

owocki reviewed Aug 2, 2018

View reviewed changes

owocki previously approved these changes Aug 2, 2018

View reviewed changes

mbeacom added 2 commits August 2, 2018 15:12

Merge branch 'master' into mark-split-create-bounty

64aa413

Update to_dict to use model_to_dict form helper

e53d8a1

mbeacom dismissed stale reviews from owocki and thelostone-mc via e53d8a1 August 2, 2018 19:18

mbeacom added 2 commits August 2, 2018 15:23

Fix import - whoops

f2f106a

Adjust to dict handling via supermodel method

4641760

mbeacom requested review from owocki and thelostone-mc August 2, 2018 19:42

owocki reviewed Aug 2, 2018

View reviewed changes

thelostone-mc approved these changes Aug 7, 2018

View reviewed changes

mbeacom merged commit 192430d into master Aug 10, 2018

mbeacom deleted the mark-split-create-bounty branch August 10, 2018 19:56

mbeacom removed the in progress label Aug 10, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split create_new_bounty kwargs building and check if once #1892

Split create_new_bounty kwargs building and check if once #1892

mbeacom commented Jul 31, 2018

codecov bot commented Jul 31, 2018 •

edited

Loading

thelostone-mc Aug 2, 2018

thelostone-mc left a comment

owocki Aug 2, 2018

owocki Aug 2, 2018

mbeacom Aug 2, 2018

mbeacom Aug 2, 2018

owocki left a comment

mbeacom commented Aug 2, 2018

owocki Aug 2, 2018

owocki Aug 2, 2018

owocki left a comment

mbeacom commented Aug 2, 2018

owocki commented Aug 6, 2018

thelostone-mc left a comment

Split create_new_bounty kwargs building and check if once #1892

Split create_new_bounty kwargs building and check if once #1892

Conversation

mbeacom commented Jul 31, 2018

Description

Checklist

Affected core subsystem(s)

Testing

codecov bot commented Jul 31, 2018 • edited Loading

Codecov Report

thelostone-mc Aug 2, 2018

Choose a reason for hiding this comment

thelostone-mc left a comment

Choose a reason for hiding this comment

owocki Aug 2, 2018

Choose a reason for hiding this comment

owocki Aug 2, 2018

Choose a reason for hiding this comment

mbeacom Aug 2, 2018

Choose a reason for hiding this comment

mbeacom Aug 2, 2018

Choose a reason for hiding this comment

owocki left a comment

Choose a reason for hiding this comment

mbeacom commented Aug 2, 2018

owocki Aug 2, 2018

Choose a reason for hiding this comment

owocki Aug 2, 2018

Choose a reason for hiding this comment

owocki left a comment

Choose a reason for hiding this comment

mbeacom commented Aug 2, 2018

owocki commented Aug 6, 2018

thelostone-mc left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 31, 2018 •

edited

Loading