Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: display filter tags + sort on mobile #1849

Merged
merged 2 commits into from
Jul 31, 2018
Merged

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jul 30, 2018

Description
Feedback from user!

screen shot 2018-07-30 at 10 09 29 pm

Fix

screen shot 2018-07-30 at 10 10 31 pm

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • css

@thelostone-mc thelostone-mc added frontend This needs frontend expertise. and removed in progress labels Jul 31, 2018
@thelostone-mc thelostone-mc requested review from mbeacom and SaptakS July 31, 2018 04:39
@codecov
Copy link

codecov bot commented Jul 31, 2018

Codecov Report

Merging #1849 into master will decrease coverage by 2.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1849      +/-   ##
=========================================
- Coverage   28.01%   25.6%   -2.41%     
=========================================
  Files         129     129              
  Lines       10471   10471              
  Branches     1395    1395              
=========================================
- Hits         2933    2681     -252     
- Misses       7431    7713     +282     
+ Partials      107      77      -30
Impacted Files Coverage Δ
...pp/marketing/management/commands/expiration_tip.py 0% <0%> (-100%) ⬇️
app/marketing/management/commands/sync_keywords.py 0% <0%> (-95.84%) ⬇️
app/marketing/management/commands/expiration.py 0% <0%> (-90.48%) ⬇️
app/marketing/management/commands/roundup.py 0% <0%> (-82.36%) ⬇️
...eting/management/commands/expiration_start_work.py 0% <0%> (-74.33%) ⬇️
...eting/management/commands/assemble_leaderboards.py 0% <0%> (-52.21%) ⬇️
...marketing/management/commands/remarket_bounties.py 0% <0%> (-50%) ⬇️
app/dashboard/signals.py 40.9% <0%> (-13.64%) ⬇️
app/dashboard/models.py 47.28% <0%> (-1.98%) ⬇️
app/git/utils.py 48.35% <0%> (-0.66%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c4dff...3281b35. Read the comment docs.

Copy link
Contributor

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SaptakS SaptakS merged commit b8f5bce into gitcoinco:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants