Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

css: fixed loading state #1752

Merged
merged 1 commit into from
Jul 17, 2018
Merged

css: fixed loading state #1752

merged 1 commit into from
Jul 17, 2018

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jul 15, 2018 •
edited
Loading

Description
  • fixed padding & merging on loading state template
  • ensures loading gif is aligned in the center
  • refactoring
  • added background color to code snippet in the issue description

screen shot 2018-07-15 at 7 39 33 pm

screen shot 2018-07-16 at 2 05 08 pm

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • css

@ghost ghost assigned thelostone-mc Jul 15, 2018
@ghost ghost added the in progress label Jul 15, 2018
@thelostone-mc thelostone-mc requested a review from SaptakS July 15, 2018 14:11
@codecov
Copy link

codecov bot commented Jul 15, 2018 •
edited
Loading

Codecov Report

Merging #1752 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1752   +/-   ##
=======================================
  Coverage   28.84%   28.84%           
=======================================
  Files         128      128           
  Lines       10067    10067           
  Branches     1328     1328           
=======================================
  Hits         2904     2904           
  Misses       7056     7056           
  Partials      107      107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed9c221...704c937. Read the comment docs.

thelostone-mc referenced this pull request Jul 16, 2018
@owocki
loading img was misaligned
715695a
@thelostone-mc thelostone-mc force-pushed the fixes branch 2 times, most recently from 6d681f9 to c3e3e27 Compare July 16, 2018 08:31
bounty: css refactor + fix
704c937 
- fixed waiting state loader
- re-indent + refactor
- added background color for code snippet
@thelostone-mc thelostone-mc merged commit 94399c3 into gitcoinco:master Jul 17, 2018
@ghost ghost removed the in progress label Jul 17, 2018
@thelostone-mc thelostone-mc deleted the fixes branch July 17, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbeacom mbeacom mbeacom approved these changes

@SaptakS SaptakS Awaiting requested review from SaptakS

Assignees

@thelostone-mc thelostone-mc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thelostone-mc @mbeacom