Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contributor_landing: added newsletter #1689

Merged
merged 1 commit into from
Jul 11, 2018
Merged

contributor_landing: added newsletter #1689

merged 1 commit into from
Jul 11, 2018

Conversation

thelostone-mc
Copy link
Member

Description

screen shot 2018-07-11 at 10 58 08 am

@thelostone-mc thelostone-mc requested review from owocki and SaptakS July 11, 2018 05:29
@ghost ghost assigned thelostone-mc Jul 11, 2018
@ghost ghost added the in progress label Jul 11, 2018
@codecov
Copy link

codecov bot commented Jul 11, 2018

Codecov Report

Merging #1689 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1689   +/-   ##
=======================================
  Coverage   29.15%   29.15%           
=======================================
  Files         134      134           
  Lines       10062    10062           
  Branches     1319     1319           
=======================================
  Hits         2934     2934           
  Misses       7023     7023           
  Partials      105      105
Impacted Files Coverage Δ
app/retail/views.py 36.77% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ec4e32...81978b5. Read the comment docs.

SaptakS
SaptakS approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SaptakS SaptakS merged commit 3295721 into gitcoinco:master Jul 11, 2018
@ghost ghost removed the in progress label Jul 11, 2018
@owocki
Copy link
Contributor

owocki commented Jul 11, 2018

@SaptakS @thelostone-mc @PixelantDesign can we add some copy under the email capture taht says:

Emails once a week. We'll never sell your info to anyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaptakS SaptakS SaptakS approved these changes

@owocki owocki Awaiting requested review from owocki

Assignees

@thelostone-mc thelostone-mc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thelostone-mc @owocki @SaptakS