fix for https://github.com/gitcoinco/web/issues/1661 #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Closed
| @@ -71,9 +71,9 @@ def add_arguments(self, parser): | |||
|
|
|||
| def handle(self, *args, **options): | |||
| force_refresh = options['force_refresh'] | |||
| if force_refresh: | |||
| Activity.objects.all().delete() | |||
| user_profile = Profile.objects.filter(handle__iexact=fulfillment.fulfiller_github_username).first() | ||
| if not user_profile: | ||
| user_profile = sync_profile(fulfillment.fulfiller_github_username) | ||
| funder_actions = ['new_bounty', 'worker_approved', 'killed_bounty', 'increased_bounty', 'worker_rejected'] |
There was a problem hiding this comment.
should we also cover start / stop work here ?
There was a problem hiding this comment.
those are not funder actions.. those are fulfiller actions, no?
Codecov Report
@@ Coverage Diff @@
## master #1662 +/- ##
==========================================
- Coverage 29.16% 29.15% -0.02%
==========================================
Files 134 134
Lines 10056 10060 +4
Branches 1317 1319 +2
==========================================
Hits 2933 2933
- Misses 7018 7022 +4
Partials 105 105
Continue to review full report at Codecov.
|
stickler-ci
reviewed
Jul 9, 2018
| for interest in latest_old_bounty.interested.all(): | ||
| new_bounty.interested.add(interest) | ||
|
|
||
| # pull the activities off the last old bounty |
| # pull the activities off the last old bounty | ||
| for activity in latest_old_bounty.activities.all(): | ||
| new_bounty.activities.add(activity) | ||
|
|
There was a problem hiding this comment.
W293 blank line contains whitespace
|
did some local testing.. merging soon |
thelostone-mc
previously approved these changes
Jul 9, 2018
|
Looked good to me. :) |
|
sorry to jump in front of you for triage @SaptakS @thelostone-mc -- i just couldnt let this stand in prod :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #1661
force_refresh, not just for current_bountyTODOS:
http://localhost:8000/actions/api/v0.1/bounties/?github_url=https://github.com/XLNT/gnarly/issues/11&network=mainnet&standard_bounties_id=677¬_current=1
and
http://localhost:8000/actions/api/v0.1/bounties/?github_url=https://github.com/XLNT/gnarly/issues/11&network=mainnet&standard_bounties_id=677
??
i think we should only care about activites related to teh current bounty and we should migrate the actions to the current_bounty=1 when we create a new current_bounty