Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update where to display how it works again #1576

Merged
merged 1 commit into from
Jun 28, 2018

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Jun 28, 2018

Description

The goal of this PR is to no longer display "How it works" on about, mission, slack, and results pages following further request/clarification.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
Testing

Locally

@mbeacom mbeacom added the frontend This needs frontend expertise. label Jun 28, 2018
@mbeacom mbeacom self-assigned this Jun 28, 2018
@ghost ghost added the in progress label Jun 28, 2018
@codecov
Copy link

codecov bot commented Jun 28, 2018

Codecov Report

Merging #1576 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1576   +/-   ##
=======================================
  Coverage   28.42%   28.42%           
=======================================
  Files         130      130           
  Lines        9588     9588           
  Branches     1240     1240           
=======================================
  Hits         2725     2725           
  Misses       6765     6765           
  Partials       98       98

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8173c32...d250696. Read the comment docs.

@SaptakS SaptakS merged commit a17034e into master Jun 28, 2018
@ghost ghost removed the in progress label Jun 28, 2018
@mbeacom mbeacom deleted the mark-update-howitworks-display branch June 28, 2018 15:15
@owocki
Copy link
Contributor

owocki commented Jul 1, 2018

@SaptakS
Copy link
Contributor

SaptakS commented Jul 1, 2018

should we add it to the footer?

I think we should.

@owocki
Copy link
Contributor

owocki commented Jul 2, 2018

i dont think i understand the rationale for doing this. someone catch me up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants