-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Contributor landing page #1459
WIP: Contributor landing page #1459
Conversation
9c4bf63
to
993c1d4
Compare
@@ -61,6 +61,30 @@ def index(request): | |||
} | |||
return TemplateResponse(request, 'index.html', context) | |||
|
|||
def contributor_landing(request): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E302 expected 2 blank lines, found 1
app/retail/views.py
Outdated
def contributor_landing(request): | ||
slides = [ | ||
("Dan Finlay", static("v2/images/testimonials/dan.jpg"), | ||
_("Once we had merged in multiple language support from a bounty, it unblocked the path to all other translations, and what better way to get lots of dif erent translations than with bounties from our community? A single tweet of publicity and we had something like 20 language requests, and 10 language pull requests. It’s been total magic."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (353 > 120 characters)
app/retail/views.py
Outdated
_("Once we had merged in multiple language support from a bounty, it unblocked the path to all other translations, and what better way to get lots of dif erent translations than with bounties from our community? A single tweet of publicity and we had something like 20 language requests, and 10 language pull requests. It’s been total magic."), | ||
'https://github.com/danfinlay', "Metamask -- Internationalization"), | ||
("Phil Elsasser", static("v2/images/testimonials/phil.jpg"), | ||
_("By design or not, there is an element of trust inherent within Gitcoin. This isn’t the bad kind of “trust” that we are all trying to move away from in a centralized world, but a much better sense of community trust that gets established through the bounty process."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (280 > 120 characters)
app/retail/views.py
Outdated
_("Gitcoin helps us to finally close out the issues we've been meaning to get around to for too long"), | ||
"https://consensys.github.io/smart-contract-best-practices/", 'Consensys Diligence -- Documentation Bounties'), | ||
("Kames CG", static("v2/images/testimonials/kames.jpg"), | ||
_("uPort is still in the process of Open Sourcing all of our code, so Gitcoin at the present moment, helps uPort plant seeds within the growing Ethereum developer community, that we expect will blossom into flourishing opportunities in the future. Put simply, as opposed to running marketing campaign, we can use bounties to stay present in front of potential developers we want to engage with."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (406 > 120 characters)
app/retail/views.py
Outdated
_("uPort is still in the process of Open Sourcing all of our code, so Gitcoin at the present moment, helps uPort plant seeds within the growing Ethereum developer community, that we expect will blossom into flourishing opportunities in the future. Put simply, as opposed to running marketing campaign, we can use bounties to stay present in front of potential developers we want to engage with."), | ||
'https://github.com/KamesCG', 'Uport'), | ||
("Piper", static("v2/images/testimonials/pipermerriam.jpg"), | ||
_("Although we’ve only hired two developers, there is no doubt that we could have sourced more. Gitcoin has been the strongest hiring signal in all of the hiring I’ve ever done."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (189 > 120 characters)
This is live on staging: https://stage.gitcoin.co/contributor |
993c1d4
to
e731b4b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1459 +/- ##
==========================================
+ Coverage 29.93% 29.94% +<.01%
==========================================
Files 130 130
Lines 9596 9608 +12
Branches 1243 1243
==========================================
+ Hits 2873 2877 +4
- Misses 6619 6627 +8
Partials 104 104
Continue to review full report at Codecov.
|
app/assets/v2/css/landing_page.css
Outdated
/** Contributor landing page **/ | ||
|
||
.explore-bounties-link { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arun1595 worth moving into it's own file?
<h1>{% trans "What is Gitcoin?" %}</h1> | ||
</div> | ||
</div> | ||
<div class="row d-flex justify-content-center align-items-center whatisit mb-4 flex-wrap"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense to throw this in it's own template ? and import them on both pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thelostone-mc I thought of it but we've different content in the landing pages and I am unsure how to pass custom HTML to a template. Can you help me with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would look along the lines of this
We'd the it as an array of image + text and render them in the contributor_landing and the funder_landing page
Both would have it's own version of whatisit
object (need a better name 😂 )
If it's too much of a trouble -> I'll take care of it later just leave a TODO
for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thelostone-mc Thanks for the explanation. I've refactored the code to include a 'What is Gitcoin' template. Do let me know how it looks.
b7f89b2
to
59b8d79
Compare
Lemme know when this good for review ^_^ |
@@ -50,17 +50,122 @@ def index(request): | |||
_("Although we’ve only hired two developers, there is no doubt that we could have sourced more. Gitcoin has been the strongest hiring signal in all of the hiring I’ve ever done."), | |||
'https://github.com/pipermerriam', 'Pipermerriam'), | |||
] | |||
|
|||
gitcoin_description = _( | |||
"A community at the intersection of blockchain and open source. A place for developers to collaborate in a new system, where open source money builds in monetization for open source repositories." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (204 > 120 characters)
app/retail/views.py
Outdated
] | ||
|
||
gitcoin_description = _( | ||
"A community for developers to collaborate and monetize their skills while working on Open Source projects through bounties." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (133 > 120 characters)
@thelostone-mc There are a few minor things missing but you can start your review when you get a chance. Thanks! |
The footer looks fixed to the bottom ! Derp derp We need the add the vertical line. If you need you can reuse code from here https://gitcoin.co/how/contributor Feels like we've got too many icons on one line. Could you resolve the conflicts too ? :P |
@PixelantDesign How it looks |
@arun1595 Would you mind resolving the conflicts here? |
@arun1595 any chance we could get this in this week ? |
956263f
to
1584b74
Compare
@thelostone-mc I've resolved the conflicts. Will address your comments shortly. |
app/retail/views.py
Outdated
def contributor_landing(request): | ||
slides = [ | ||
("Travis Mathis", static("v2/images/testimonials/gitcoiners/travis.png"), | ||
_("Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque orci ante, cursus sed maximus in, sodales ut orci. Fusce ornare, nulla quis ornare condimentum, tortor augue hendrerit nunc, in varius lacus lectus id dolor. Donec pretium, est quis placerat malesuada, dolor magna commodo justo, sit amet laoreet elit est nec mauris. Aliquam convallis varius suscipit. Curabitur rutrum libero eget nunc porta, quis cursus tortor cursus."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (454 > 120 characters)
app/retail/views.py
Outdated
_("Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque orci ante, cursus sed maximus in, sodales ut orci. Fusce ornare, nulla quis ornare condimentum, tortor augue hendrerit nunc, in varius lacus lectus id dolor. Donec pretium, est quis placerat malesuada, dolor magna commodo justo, sit amet laoreet elit est nec mauris. Aliquam convallis varius suscipit. Curabitur rutrum libero eget nunc porta, quis cursus tortor cursus."), | ||
'https://github.com/travisdmathis'), | ||
("CryptoMental", static("v2/images/testimonials/gitcoiners/cryptomental.png"), | ||
_("Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque orci ante, cursus sed maximus in, sodales ut orci. Fusce ornare, nulla quis ornare condimentum, tortor augue hendrerit nunc, in varius lacus lectus id dolor. Donec pretium, est quis placerat malesuada, dolor magna commodo justo, sit amet laoreet elit est nec mauris."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (351 > 120 characters)
app/retail/views.py
Outdated
_("Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque orci ante, cursus sed maximus in, sodales ut orci. Fusce ornare, nulla quis ornare condimentum, tortor augue hendrerit nunc, in varius lacus lectus id dolor. Donec pretium, est quis placerat malesuada, dolor magna commodo justo, sit amet laoreet elit est nec mauris."), | ||
'https://github.com/cryptomental'), | ||
("Random Internet Cat", static("v2/images/testimonials/gitcoiners/meowingtwurtle.png"), | ||
_("Integer viverra consectetur neque non maximus. Aenean hendrerit eros nunc, quis fringilla quam sodales et. Sed convallis massa ut lacus congue, sed maximus ligula venenatis. Vivamus maximus viverra tortor et dictum. Sed at ex tellus. Sed vel neque quis quam ultrices dictum."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (289 > 120 characters)
app/retail/views.py
Outdated
_("Integer viverra consectetur neque non maximus. Aenean hendrerit eros nunc, quis fringilla quam sodales et. Sed convallis massa ut lacus congue, sed maximus ligula venenatis. Vivamus maximus viverra tortor et dictum. Sed at ex tellus. Sed vel neque quis quam ultrices dictum."), | ||
"https://github.com/meowingtwurtle"), | ||
("Bakaoh", static("v2/images/testimonials/gitcoiners/bakaoh.png"), | ||
_("Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque orci ante, cursus sed maximus in, sodales ut orci. Fusce ornare, nulla quis ornare condimentum, tortor augue hendrerit nunc, in varius lacus lectus id dolor. Donec pretium, est quis placerat malesuada, dolor magna commodo justo, sit amet laoreet elit est nec mauris."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (351 > 120 characters)
app/retail/views.py
Outdated
_("Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque orci ante, cursus sed maximus in, sodales ut orci. Fusce ornare, nulla quis ornare condimentum, tortor augue hendrerit nunc, in varius lacus lectus id dolor. Donec pretium, est quis placerat malesuada, dolor magna commodo justo, sit amet laoreet elit est nec mauris."), | ||
'https://github.com/bakaoh'), | ||
("Nikita Kudryavtsev", static("v2/images/testimonials/gitcoiners/nikita.jpeg"), | ||
_("Integer viverra consectetur neque non maximus. Aenean hendrerit eros nunc, quis fringilla quam sodales et. Sed convallis massa ut lacus congue, sed maximus ligula venenatis. Vivamus maximus viverra tortor et dictum. Sed at ex tellus. Sed vel neque quis quam ultrices dictum."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (289 > 120 characters)
app/retail/views.py
Outdated
] | ||
|
||
gitcoin_description = _( | ||
"A community for developers to collaborate and monetize their skills while working on Open Source projects through bounties." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (133 > 120 characters)
The lastest is on staging right now: https://stage.gitcoin.co/ |
- update the green developer bar - update cryptomentals testimonial - add header "Repos Using Gitcoin" - reword "All that's left to do is to join Gitcoin"
app/retail/views.py
Outdated
_("Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque orci ante, cursus sed maximus in, sodales ut orci. Fusce ornare, nulla quis ornare condimentum, tortor augue hendrerit nunc, in varius lacus lectus id dolor. Donec pretium, est quis placerat malesuada, dolor magna commodo justo, sit amet laoreet elit est nec mauris. Aliquam convallis varius suscipit. Curabitur rutrum libero eget nunc porta, quis cursus tortor cursus."), | ||
'https://github.com/travisdmathis'), | ||
("CryptoMental", static("v2/images/testimonials/gitcoiners/cryptomental.png"), | ||
_(" think the great thing about GitCoin is how easy it is for projects to reach out to worldwide talent. GitCoin helps to find people who have time to contribute and increase speed of project development. Thanks to GitCoin a bunch of interesting OpenSource projects got my attention!"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (295 > 120 characters)
app/retail/views.py
Outdated
_(" think the great thing about GitCoin is how easy it is for projects to reach out to worldwide talent. GitCoin helps to find people who have time to contribute and increase speed of project development. Thanks to GitCoin a bunch of interesting OpenSource projects got my attention!"), | ||
'https://github.com/cryptomental'), | ||
("Random Internet Cat", static("v2/images/testimonials/gitcoiners/meowingtwurtle.png"), | ||
_("Integer viverra consectetur neque non maximus. Aenean hendrerit eros nunc, quis fringilla quam sodales et. Sed convallis massa ut lacus congue, sed maximus ligula venenatis. Vivamus maximus viverra tortor et dictum. Sed at ex tellus. Sed vel neque quis quam ultrices dictum."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (289 > 120 characters)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code seems sane to me. @mbeacom @thelostone-mc @SaptakS let me know waht you think
- update the green developer bar - update cryptomentals testimonial - add header "Repos Using Gitcoin" - reword "All that's left to do is to join Gitcoin" - made button text white - first line of each p was lined up
c2a86a0
to
7aced61
Compare
…to contributor-landing-page
app/retail/views.py
Outdated
def contributor_landing(request): | ||
slides = [ | ||
("Daniel", static("v2/images/testimonials/gitcoiners/daniel.jpeg"), | ||
_("When I found Gitcoin I was gladly surprised that it took one thing and did it well. It took the Ethereum tech and used it as a bridge to technology with open source Jobs. Even though Gitcoin is still in it’s early stages, I think it’s filled with potential to grow."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (282 > 120 characters)
app/retail/views.py
Outdated
_("When I found Gitcoin I was gladly surprised that it took one thing and did it well. It took the Ethereum tech and used it as a bridge to technology with open source Jobs. Even though Gitcoin is still in it’s early stages, I think it’s filled with potential to grow."), | ||
'https://github.com/dmerrill6'), | ||
("CryptoMental", static("v2/images/testimonials/gitcoiners/cryptomental.png"), | ||
_(" think the great thing about GitCoin is how easy it is for projects to reach out to worldwide talent. GitCoin helps to find people who have time to contribute and increase speed of project development. Thanks to GitCoin a bunch of interesting OpenSource projects got my attention!"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (295 > 120 characters)
app/retail/views.py
Outdated
_(" think the great thing about GitCoin is how easy it is for projects to reach out to worldwide talent. GitCoin helps to find people who have time to contribute and increase speed of project development. Thanks to GitCoin a bunch of interesting OpenSource projects got my attention!"), | ||
'https://github.com/cryptomental'), | ||
("Elan", static("v2/images/testimonials/gitcoiners/elan.jpeg"), | ||
_("The bounty process with Gitcoin is pretty amazing. Just go on the website, find an issue you can work on, you claim it. All you do then is submit your code to Github, get the code merged. Once it’s merged, the smart contract kicks in and sends the money to your Ethereum account. The whole process is pretty smooth. There’s a giant slack community. It puts the freelance market back in the hands of the community!"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (434 > 120 characters)
app/retail/views.py
Outdated
_("The bounty process with Gitcoin is pretty amazing. Just go on the website, find an issue you can work on, you claim it. All you do then is submit your code to Github, get the code merged. Once it’s merged, the smart contract kicks in and sends the money to your Ethereum account. The whole process is pretty smooth. There’s a giant slack community. It puts the freelance market back in the hands of the community!"), | ||
"https://github.com/elaniobro"), | ||
("Jack", static("v2/images/testimonials/gitcoiners/jack.jpeg"), | ||
_("I really like Gitcoin because it’s allowed me to get involved in some really interesting Open Source Projects. I’ve written code for MyEtherWallet and Gitcoin itself. I think Gitcoin is becoming a great asset for the Ethereum ecosystem."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (253 > 120 characters)
app/retail/views.py
Outdated
_("I really like Gitcoin because it’s allowed me to get involved in some really interesting Open Source Projects. I’ve written code for MyEtherWallet and Gitcoin itself. I think Gitcoin is becoming a great asset for the Ethereum ecosystem."), | ||
'https://github.com/jclancy93'), | ||
("Miguel Angel Rodriguez Bermudez", static("v2/images/testimonials/gitcoiners/miguel.jpeg"), | ||
_("I came across Gitcoin 3 months ago. I was hearing lots of ideas about projects involving cryptocurrencies, and I kept thinking \"what about open source projects?\". I see Gitcoin as the next level of freelance, where you can not only help repos on Github, but get money out of it. It is that simple and it works."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (330 > 120 characters)
app/retail/views.py
Outdated
] | ||
|
||
gitcoin_description = _( | ||
"A community for developers to collaborate and monetize their skills while working on Open Source projects through bounties." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (133 > 120 characters)
app/retail/views.py
Outdated
("Miguel Angel Rodriguez Bermudez", static("v2/images/testimonials/gitcoiners/miguel.jpeg"), | ||
_("I came across Gitcoin 3 months ago. I was hearing lots of ideas about projects involving cryptocurrencies, and I kept thinking \"what about open source projects?\". I see Gitcoin as the next level of freelance, where you can not only help repos on Github, but get money out of it. It is that simple and it works."), | ||
'https://github.com/marbrb'), | ||
("Octavio Amuchástegui", static("v2/images/testimonials/gitcoiners/octavioamu.jpeg"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E131 continuation line unaligned for hanging indent
app/retail/views.py
Outdated
_("I came across Gitcoin 3 months ago. I was hearing lots of ideas about projects involving cryptocurrencies, and I kept thinking \"what about open source projects?\". I see Gitcoin as the next level of freelance, where you can not only help repos on Github, but get money out of it. It is that simple and it works."), | ||
'https://github.com/marbrb'), | ||
("Octavio Amuchástegui", static("v2/images/testimonials/gitcoiners/octavioamu.jpeg"), | ||
_("I'm in love with Gitcoin. It isn't only a platform, it's a community that gives me the opportunity to open my network and work with amazing top technology projects and earn some money in a way I'm visible to the dev community and work opportunities. Open source is amazing, and is even better to make a living from it, I think is the future of development."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E128 continuation line under-indented for visual indent
E501 line too long (371 > 120 characters)
app/retail/views.py
Outdated
'https://github.com/marbrb'), | ||
("Octavio Amuchástegui", static("v2/images/testimonials/gitcoiners/octavioamu.jpeg"), | ||
_("I'm in love with Gitcoin. It isn't only a platform, it's a community that gives me the opportunity to open my network and work with amazing top technology projects and earn some money in a way I'm visible to the dev community and work opportunities. Open source is amazing, and is even better to make a living from it, I think is the future of development."), | ||
'https://github.com/octavioamu') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E128 continuation line under-indented for visual indent
app/retail/views.py
Outdated
] | ||
|
||
gitcoin_description = _( | ||
"A community for developers to collaborate and monetize their skills while working on Open Source projects through bounties." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (133 > 120 characters)
32191d0
to
27087c0
Compare
app/retail/views.py
Outdated
_("I came across Gitcoin 3 months ago. I was hearing lots of ideas about projects involving cryptocurrencies, and I kept thinking \"what about open source projects?\". I see Gitcoin as the next level of freelance, where you can not only help repos on Github, but get money out of it. It is that simple and it works."), | ||
'https://github.com/marbrb'), | ||
("Octavio Amuchástegui", static("v2/images/testimonials/gitcoiners/octavioamu.jpeg"), | ||
_("I'm in love with Gitcoin. It isn't only a platform, it's a community that gives me the opportunity to open my network and work with amazing top technology projects and earn some money in a way I'm visible to the dev community and work opportunities. Open source is amazing, and is even better to make a living from it, I think is the future of development."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (371 > 120 characters)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This is a WIP. Not ready for review yet.
Checklist
Affected core subsystem(s)
UI
Refers/Fixes
Fixes #1386