Update top banners in different bounty flow pages #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #1365 +/- ##
==========================================
- Coverage 30.64% 30.29% -0.36%
==========================================
Files 124 125 +1
Lines 8790 9025 +235
Branches 1141 1158 +17
==========================================
+ Hits 2694 2734 +40
- Misses 5988 6182 +194
- Partials 108 109 +1
Continue to review full report at Codecov.
|
SaptakS
changed the title
| - {% trans "or" %} - | ||
| <br> | ||
| <a class="button button--primary mt-3 pulseClick" role="button" id="submit" href="{% url 'faucet' %}" target="_blank" rel="noopener noreferrer">{% trans "View Faucet" %}</a> | ||
| <br><br> |
There was a problem hiding this comment.
wanna swap this out by padding mb-2 to <a> ?
| <div class="row no-gutters"> | ||
| <div class="col-sm-12 col-lg-3"> | ||
| <div class="row no-gutters metamask-banner"> | ||
| <div class="col-sm-12 col-lg-2"> |
| </p> | ||
| </div> | ||
| <div class="col-lg-2 col-sm-12"> | ||
| <img src="{% static "v2/images/Box.svg" %}"> |
There was a problem hiding this comment.
rename to box.svg cause I guess that's what we've been doing soo far in this repo
There was a problem hiding this comment.
Well, there are mixed namings, so I didn't refactor. If you want, I will.
mbeacom
reviewed
Jun 4, 2018
app/assets/v2/images/Box.svg
Outdated
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <svg width="97px" height="92px" viewBox="0 0 97 92" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> | ||
| <!-- Generator: Sketch 49 (51002) - http://www.bohemiancoding.com/sketch --> | ||
| <title>Metamask Copy 3</title> |
There was a problem hiding this comment.
We'll want to squash this with svgo.
app/assets/v2/images/Refund.svg
Outdated
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <svg width="97px" height="92px" viewBox="0 0 97 92" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> | ||
| <!-- Generator: Sketch 49 (51002) - http://www.bohemiancoding.com/sketch --> | ||
| <title>Metamask Copy 4</title> |
SaptakS
changed the title
|
@mbeacom renamed files and compressed them |
…into fix/banner-text-alignment
mbeacom
previously approved these changes
Jun 5, 2018
mbeacom
added
mergeable
frontend
|
didnt test but LGTM . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Affected core subsystem(s)
Testing
Refers/Fixes