Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FontAwesome static refs #1360

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Fix FontAwesome static refs #1360

merged 2 commits into from
Jun 4, 2018

Conversation

mbeacom
Copy link
Contributor

@mbeacom mbeacom commented Jun 4, 2018

Description

The goal of this PR is to resolve the static handling issue with link entries for FA css.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

frontend, static, css

Testing

Local

@mbeacom mbeacom added the frontend This needs frontend expertise. label Jun 4, 2018
@mbeacom mbeacom self-assigned this Jun 4, 2018
@mbeacom mbeacom requested a review from thelostone-mc June 4, 2018 15:40
@ghost ghost added the in progress label Jun 4, 2018
@mbeacom mbeacom requested a review from SaptakS June 4, 2018 15:41
@mbeacom mbeacom changed the title Fix static fontawesome Fix FontAwesome static refs Jun 4, 2018
@codecov
Copy link

codecov bot commented Jun 4, 2018

Codecov Report

Merging #1360 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1360   +/-   ##
=======================================
  Coverage   30.64%   30.64%           
=======================================
  Files         124      124           
  Lines        8790     8790           
  Branches     1141     1141           
=======================================
  Hits         2694     2694           
  Misses       5988     5988           
  Partials      108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5310da...ab9ab2c. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thelostone-mc thelostone-mc merged commit 3febe8d into master Jun 4, 2018
@ghost ghost removed the in progress label Jun 4, 2018
@thelostone-mc thelostone-mc deleted the mark-fa-static branch June 15, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants