Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min value for hours worked input field on submit work form #1350

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

arku
Copy link
Contributor

@arku arku commented Jun 3, 2018

Description

Currently, we're not validating the hours worked input field. So, a user cannot enter negative numbers though it doesn't make sense. This PR adds a minimum value of 0.25 to the input field.

Note: This is a really minor thing as an average gitcoiner wouldn't enter negative numbers but it was bugging me so I decided to submit a patch.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Testing

I did, manually

Screenshots
Before

image

After

image

@codecov
Copy link

codecov bot commented Jun 3, 2018

Codecov Report

Merging #1350 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1350   +/-   ##
=======================================
  Coverage   30.63%   30.63%           
=======================================
  Files         124      124           
  Lines        8783     8783           
  Branches     1141     1141           
=======================================
  Hits         2691     2691           
  Misses       5984     5984           
  Partials      108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0eeb8...235c069. Read the comment docs.

@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.05 ETH (29.23 USD @ $584.51/ETH) has been granted to @arun1595 for this issue from owocki. ⚡️

The sender had the following public comments:

thx for all the work recently

Nice work @arun1595! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.035 ETH (20.52 USD @ $586.26/ETH) attached to it.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Cancelled


The funding of 0.035 ETH (20.52 USD @ $586.26/ETH) attached to this issue has been cancelled by the bounty submitter

@owocki
Copy link
Contributor

owocki commented Jun 4, 2018

accidently funded this.. sorry, wrong issue

@SaptakS SaptakS merged commit 26a1e0d into gitcoinco:master Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants