Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feedback icons overlap with input value and center the icons vertically #1349

Merged
merged 1 commit into from
Jun 3, 2018

Conversation

arku
Copy link
Contributor

@arku arku commented Jun 3, 2018

Description
  • Fix feedback icons overlap with the input field values
  • Center the feedback icons vertically
Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

UI

Testing

I did.

Refers/Fixes

Fixes #1348

Screenshots

Before

image

After

image

@codecov
Copy link

codecov bot commented Jun 3, 2018

Codecov Report

Merging #1349 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1349   +/-   ##
=======================================
  Coverage   30.63%   30.63%           
=======================================
  Files         124      124           
  Lines        8783     8783           
  Branches     1141     1141           
=======================================
  Hits         2691     2691           
  Misses       5984     5984           
  Partials      108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c23fccc...fbc69c0. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for catching that ^_^
I meant to getting to that sometime this week

@thelostone-mc thelostone-mc added ui bug This is something that isn't working as intended. labels Jun 3, 2018
@thelostone-mc thelostone-mc merged commit 4c0eeb8 into gitcoinco:master Jun 3, 2018
@arku arku deleted the form-input-icon-bug branch June 3, 2018 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is something that isn't working as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form input feedback icon overlaps with a long input field value
2 participants